Fixes #2496. Fix co19 tests that became failing after test runner upd…

…ate (#2497) Fix co19 tests that became failing after test runner update
dart-lang · Feb 15, 2024 · 8a066d4 · 8a066d4
1 parent 5eb438e
commit 8a066d4
Show file tree

Hide file tree

Showing 43 changed files with 232 additions and 104 deletions.
diff --git a/Language/Libraries_and_Scripts/Parts/compilation_t04.dart b/Language/Libraries_and_Scripts/Parts/compilation_t04.dart
@@ -7,14 +7,15 @@
 /// The top-level declarations at that URI are then compiled by the Dart compiler
 /// in the scope of the current library. It is a compile-time error if the
 /// contents of the URI are not a valid part declaration.
+///
 /// @description Checks that more than one part can be included in a library
-/// without errors as long as there're no name conflicts.
+/// without errors as long as there are no name conflicts.
 /// @author rodionov
 
 library Parts_test_lib;
 import "../../../Utils/expect.dart";
-part "part_0.dart";
 part "part_3.dart";
+part "part_12.dart";
 
 main() {
   // get/set

diff --git a/Language/Libraries_and_Scripts/Parts/compilation_t11.dart b/Language/Libraries_and_Scripts/Parts/compilation_t11.dart
@@ -10,7 +10,7 @@
 /// @description Checks that it is a compile-time error when the included part
 /// unit contains an import declaration.
 /// @author rodionov
-/// @issue 44990
+/// @issue 44990, 54661
 
 part "part_9.dart";
 //   ^

diff --git a/Language/Libraries_and_Scripts/Parts/compilation_t15.dart b/Language/Libraries_and_Scripts/Parts/compilation_t15.dart
@@ -7,21 +7,24 @@
 /// The top-level declarations at that URI are then compiled by the Dart compiler
 /// in the scope of the current library. It is a compile-time error if the
 /// contents of the URI are not a valid part declaration.
-/// @description Checks that partDirective, partHeader and libraryName can
+///
+/// @description Checks that `partDirective`, `partHeader` and `libraryName` may
 /// contain metadata.
 /// @author kaigorodov
 
 @Annot()
 library Parts_test_lib;
+
 import "../../../Utils/expect.dart";
-@Annot1()
-part "part_0.dart";
+
 @Annot1.nn(1)
 part "part_3.dart";
+@Annot1()
+part "part_12.dart";
 
 class Annot1 {
   final int n;
-  const Annot1():n=0;
+  const Annot1() : n = 0;
   const Annot1.nn(int this.n);
 }
 
@@ -33,8 +36,8 @@ main() {
   Expect.equals(false, value);
   value = foo;
   Expect.equals("foo", value);
-  value = [1,2,3,4];
-  Expect.listEquals([1,2,3,4], value);
+  value = [1, 2, 3, 4];
+  Expect.listEquals([1, 2, 3, 4], value);
 
   // variables
   Expect.isTrue("foo" == foo);

diff --git a/Language/Libraries_and_Scripts/Parts/part_9.dart b/Language/Libraries_and_Scripts/Parts/part_9.dart
@@ -2,8 +2,12 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-  part of Parts_test_lib;
-  import 'part_9_lib.dart';
-//^^^^^^^^^^^^^^^^^^^^^^^^
-// [analyzer] unspecified
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
+/**/part of Parts_test_lib;
+/**/import 'part_9_lib.dart';
+//  ^^^^^^
 // [cfe] unspecified
diff --git a/Language/Libraries_and_Scripts/Parts/syntax_t04.dart b/Language/Libraries_and_Scripts/Parts/syntax_t04.dart
@@ -25,7 +25,7 @@
 
 
 library Parts_test_lib;
-#part "part_0.dart";
+#part "part_12.dart";
 //^
 // [analyzer] unspecified
 // [cfe] unspecified

diff --git a/Language/Libraries_and_Scripts/definition_syntax_t04_lib.dart b/Language/Libraries_and_Scripts/definition_syntax_t04_lib.dart
@@ -2,13 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-
 part "definition_syntax_t04_lib_p1.dart";
-//   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
 
-  library Definition_Syntax_t04_lib;
-//^^^^^^^
+/**/library Definition_Syntax_t04_lib;
+//  ^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified
diff --git a/Language/Libraries_and_Scripts/definition_syntax_t18.dart b/Language/Libraries_and_Scripts/definition_syntax_t18.dart
@@ -19,12 +19,15 @@
 /// library begins with the word library (possibly prefaced with any applicable
 /// metadata annotations), followed by a qualified identifier that gives the
 /// name of the library.
-/// @description Checks that it is a compile-time error if the library directive
-/// is missing the library name.
+///
+/// An implicitly named library has the empty string as its name
+///
+/// @description Checks that it is not an error if a library name is missing in
+/// the library directive of the imported library.
 /// @author vasya
 /// @issue 44990
 
-import "definition_syntax_t18_lib.dart";
+library;
 
 main() {
   var someVar = 0;

diff --git a/Language/Libraries_and_Scripts/definition_syntax_t18_lib.dart b/Language/Libraries_and_Scripts/definition_syntax_t18_lib.dart
diff --git a/Language/Libraries_and_Scripts/top_level_syntax_t06_lib.dart b/Language/Libraries_and_Scripts/top_level_syntax_t06_lib.dart
@@ -2,12 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-
 library Libraries_and_Scripts_A01_t06;
 
 f() {}
 
-  f()
-//^
+/**/f();
+//  ^
 // [analyzer] unspecified
 // [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/assert_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/assert_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of assert;
 //      ^^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/break_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/break_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of break;
 //      ^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/case_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/case_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of case;
 //      ^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/catch_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/catch_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of catch;
 //      ^^^^^
-// [analyzer] unspecified
 // [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/class_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/class_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of class;
 //      ^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/const_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/const_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of const;
 //      ^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/continue_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/continue_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of continue;
 //      ^^^^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/default_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/default_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of default;
 //      ^^^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/do_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/do_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of do;
 //      ^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/else_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/else_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of else;
 //      ^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/enum_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/enum_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of enum;
 //      ^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/extends_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/extends_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of extends;
 //      ^^^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/false_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/false_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of false;
 //      ^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/final_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/final_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of final;
 //      ^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/finally_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/finally_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of finally;
 //      ^^^^^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified
diff --git a/Language/Reference/Lexical_Rules/Reserved_Words/for_lib.dart b/Language/Reference/Lexical_Rules/Reserved_Words/for_lib.dart
@@ -2,7 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO (sgrekhov) Add expected analyzer error below. For now (Feb, 2024)
+// analyzer doesn't analyze parts, this error is not reported by the analyzer
+// and this is not an error but an intended behavior.
+// See https://github.com/dart-lang/sdk/issues/54661
+
 part of for;
 //      ^^^
-// [analyzer] unspecified
-// [cfe] unspecified
+// [cfe] unspecified