-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1400. [Views] Syntax tests added #1498
Changes from 2 commits
8f24016
c356b75
41ca129
5cf9b62
9bb1e56
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
/// @assertion A rule for <viewDeclaration> is added to the grammar, along with | ||
/// some rules for elements used in view declarations: | ||
/// | ||
/// <viewDeclaration> ::= | ||
/// 'view' 'class' <typeIdentifier> <typeParameters>? | ||
/// <viewPrimaryConstructor>? | ||
/// <interfaces>? | ||
/// '{' | ||
/// (<metadata> <viewMemberDeclaration>)* | ||
/// '}' | ||
/// | ||
/// <viewPrimaryConstructor> ::= | ||
/// '(' <type> <identifier> ')' | ||
/// | ||
/// <viewMemberDeclaration> ::= | ||
/// <classMemberDefinition> | ||
/// The token `view` is made a built-in identifier. | ||
/// | ||
/// @description Checks that it is a compile-time error to declare a function | ||
/// named `view` | ||
/// @author sgrekhov22@gmail.com | ||
|
||
// SharedOptions=--enable-experiment=extension-types | ||
|
||
void view() {} | ||
// ^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
|
||
main() { | ||
view(); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
/// @assertion A rule for <viewDeclaration> is added to the grammar, along with | ||
/// some rules for elements used in view declarations: | ||
/// | ||
/// <viewDeclaration> ::= | ||
/// 'view' 'class' <typeIdentifier> <typeParameters>? | ||
/// <viewPrimaryConstructor>? | ||
/// <interfaces>? | ||
/// '{' | ||
/// (<metadata> <viewMemberDeclaration>)* | ||
/// '}' | ||
/// | ||
/// <viewPrimaryConstructor> ::= | ||
/// '(' <type> <identifier> ')' | ||
/// | ||
/// <viewMemberDeclaration> ::= | ||
/// <classMemberDefinition> | ||
/// The token `view` is made a built-in identifier. | ||
/// | ||
/// @description Checks that it is a compile-time error to declare a class | ||
/// named `view` | ||
/// @author sgrekhov22@gmail.com | ||
|
||
// SharedOptions=--enable-experiment=extension-types | ||
|
||
class view { | ||
// ^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
} | ||
|
||
main() { | ||
view(); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
/// @assertion A rule for <viewDeclaration> is added to the grammar, along with | ||
/// some rules for elements used in view declarations: | ||
/// | ||
/// <viewDeclaration> ::= | ||
/// 'view' 'class' <typeIdentifier> <typeParameters>? | ||
/// <viewPrimaryConstructor>? | ||
/// <interfaces>? | ||
/// '{' | ||
/// (<metadata> <viewMemberDeclaration>)* | ||
/// '}' | ||
/// | ||
/// <viewPrimaryConstructor> ::= | ||
/// '(' <type> <identifier> ')' | ||
/// | ||
/// <viewMemberDeclaration> ::= | ||
/// <classMemberDefinition> | ||
/// The token `view` is made a built-in identifier. | ||
/// | ||
/// @description Checks that it is a compile-time error to declare a mixin | ||
/// named `view` | ||
/// @author sgrekhov22@gmail.com | ||
|
||
// SharedOptions=--enable-experiment=extension-types | ||
|
||
mixin view on Object { | ||
// ^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
} | ||
|
||
class VA = Object with view; | ||
|
||
main() { | ||
VA(); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
/// @assertion A rule for <viewDeclaration> is added to the grammar, along with | ||
/// some rules for elements used in view declarations: | ||
/// | ||
/// <viewDeclaration> ::= | ||
/// 'view' 'class' <typeIdentifier> <typeParameters>? | ||
/// <viewPrimaryConstructor>? | ||
/// <interfaces>? | ||
/// '{' | ||
/// (<metadata> <viewMemberDeclaration>)* | ||
/// '}' | ||
/// | ||
/// <viewPrimaryConstructor> ::= | ||
/// '(' <type> <identifier> ')' | ||
/// | ||
/// <viewMemberDeclaration> ::= | ||
/// <classMemberDefinition> | ||
/// The token `view` is made a built-in identifier. | ||
/// | ||
/// @description Checks that it is a compile-time error to declare a variable | ||
/// named `view` | ||
eernstg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/// @author sgrekhov22@gmail.com | ||
|
||
// SharedOptions=--enable-experiment=extension-types | ||
|
||
main() { | ||
int view = 42; | ||
// ^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
/// @assertion A rule for <viewDeclaration> is added to the grammar, along with | ||
/// some rules for elements used in view declarations: | ||
/// | ||
/// <viewDeclaration> ::= | ||
/// 'view' 'class' <typeIdentifier> <typeParameters>? | ||
/// <viewPrimaryConstructor>? | ||
/// <interfaces>? | ||
/// '{' | ||
/// (<metadata> <viewMemberDeclaration>)* | ||
/// '}' | ||
/// | ||
/// <viewPrimaryConstructor> ::= | ||
/// '(' <type> <identifier> ')' | ||
/// | ||
/// <viewMemberDeclaration> ::= | ||
/// <classMemberDefinition> | ||
/// The token `view` is made a built-in identifier. | ||
/// | ||
/// @description Checks that it is a compile-time error to declare a constant | ||
/// named `view` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again not an error. |
||
/// @author sgrekhov22@gmail.com | ||
|
||
// SharedOptions=--enable-experiment=extension-types | ||
|
||
const view = 42; | ||
// ^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
|
||
@view class View { | ||
final int id; | ||
View(this.id); | ||
} | ||
|
||
main() { | ||
View(0); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
/// @assertion A rule for <viewDeclaration> is added to the grammar, along with | ||
/// some rules for elements used in view declarations: | ||
/// | ||
/// <viewDeclaration> ::= | ||
/// 'view' 'class' <typeIdentifier> <typeParameters>? | ||
/// <viewPrimaryConstructor>? | ||
/// <interfaces>? | ||
/// '{' | ||
/// (<metadata> <viewMemberDeclaration>)* | ||
/// '}' | ||
/// | ||
/// <viewPrimaryConstructor> ::= | ||
/// '(' <type> <identifier> ')' | ||
/// | ||
/// <viewMemberDeclaration> ::= | ||
/// <classMemberDefinition> | ||
/// The token `view` is made a built-in identifier. | ||
/// | ||
/// @description Checks that it is a compile-time error import a library with | ||
/// import prefix `view` | ||
/// @author sgrekhov22@gmail.com | ||
|
||
// SharedOptions=--enable-experiment=extension-types | ||
|
||
import "views_lib.dart" as view; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes! A prefix is not a type, but it is indeed included among the things that can't have a name which is a built-in identifier. I forgot to mention that above. |
||
// ^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
|
||
main() { | ||
view.x; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
/// @assertion A rule for <viewDeclaration> is added to the grammar, along with | ||
/// some rules for elements used in view declarations: | ||
/// | ||
/// <viewDeclaration> ::= | ||
/// 'view' 'class' <typeIdentifier> <typeParameters>? | ||
/// <viewPrimaryConstructor>? | ||
/// <interfaces>? | ||
/// '{' | ||
/// (<metadata> <viewMemberDeclaration>)* | ||
/// '}' | ||
/// | ||
/// <viewPrimaryConstructor> ::= | ||
/// '(' <type> <identifier> ')' | ||
/// | ||
/// <viewMemberDeclaration> ::= | ||
/// <classMemberDefinition> | ||
/// The token `view` is made a built-in identifier. | ||
/// | ||
/// @description Checks that it is a compile-time error to declare a type alias | ||
/// named `view` | ||
/// @author sgrekhov22@gmail.com | ||
|
||
// SharedOptions=--enable-experiment=extension-types | ||
|
||
typedef view = String; | ||
// ^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
|
||
main() { | ||
view s = ""; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
/// @assertion A rule for <viewDeclaration> is added to the grammar, along with | ||
/// some rules for elements used in view declarations: | ||
/// | ||
/// <viewDeclaration> ::= | ||
/// 'view' 'class' <typeIdentifier> <typeParameters>? | ||
/// <viewPrimaryConstructor>? | ||
/// <interfaces>? | ||
/// '{' | ||
/// (<metadata> <viewMemberDeclaration>)* | ||
/// '}' | ||
/// | ||
/// <viewPrimaryConstructor> ::= | ||
/// '(' <type> <identifier> ')' | ||
/// | ||
/// <viewMemberDeclaration> ::= | ||
/// <classMemberDefinition> | ||
/// ... | ||
/// If a view declaration named View includes a <viewPrimaryConstructor> then it | ||
/// is a compile-time error if the declaration includes a constructor | ||
/// declaration named View. (But it can still contain other constructors.) | ||
/// | ||
/// @description Checks that it is a compile-time error if a view declaration | ||
/// named `View` includes a <viewPrimaryConstructor> and includes a constructor | ||
/// named `View` | ||
/// @author sgrekhov22@gmail.com | ||
|
||
// SharedOptions=--enable-experiment=extension-types | ||
|
||
view class View1(int id) { | ||
View1(this.id); | ||
//^^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
} | ||
|
||
view class View2(int id) { | ||
View2(int id, int x) {} | ||
//^^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
} | ||
|
||
view class View3(int id) { | ||
View3(); | ||
//^^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
} | ||
|
||
view class View4(int id) { | ||
factory View4(int id) => View4.named(id); | ||
// ^^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
View4.named(int x) : id = x; | ||
} | ||
|
||
main() { | ||
print(View1); | ||
print(View2); | ||
print(View3); | ||
print(View4); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
/// @assertion A rule for <viewDeclaration> is added to the grammar, along with | ||
/// some rules for elements used in view declarations: | ||
/// | ||
/// <viewDeclaration> ::= | ||
/// 'view' 'class' <typeIdentifier> <typeParameters>? | ||
/// <viewPrimaryConstructor>? | ||
/// <interfaces>? | ||
/// '{' | ||
/// (<metadata> <viewMemberDeclaration>)* | ||
/// '}' | ||
/// | ||
/// <viewPrimaryConstructor> ::= | ||
/// '(' <type> <identifier> ')' | ||
/// | ||
/// <viewMemberDeclaration> ::= | ||
/// <classMemberDefinition> | ||
/// ... | ||
/// If a view declaration named View includes a <viewPrimaryConstructor> then it | ||
/// is a compile-time error if the declaration includes a constructor | ||
/// declaration named View. (But it can still contain other constructors.) | ||
/// | ||
/// @description Checks that it is a compile-time error if a view declaration | ||
/// named `View` includes a <viewPrimaryConstructor> with zero or more than one | ||
/// parameters | ||
/// @author sgrekhov22@gmail.com | ||
|
||
// SharedOptions=--enable-experiment=extension-types | ||
|
||
view class View1() { | ||
// ^^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
} | ||
|
||
view class View2(int id, String name) { | ||
// ^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
} | ||
|
||
view class View3(int id, {String name}) { | ||
// ^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
} | ||
|
||
view class View4(int id, [String name]) { | ||
// ^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
} | ||
|
||
main() { | ||
print(View1); | ||
print(View2); | ||
print(View3); | ||
print(View4); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that would actually not be an error. I've specified that
view
is a built-in identifier, which means that it would be an error to declare a type with that name, but other things (a function, a local variable, etc, anything-not-an-type) would be ok.