Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1400. [Views] Syntax tests added #1498

Merged
merged 5 commits into from
Oct 11, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions LanguageFeatures/Views/syntax_A01_t01.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion A rule for <viewDeclaration> is added to the grammar, along with
/// some rules for elements used in view declarations:
///
/// <viewDeclaration> ::=
/// 'view' 'class' <typeIdentifier> <typeParameters>?
/// <viewPrimaryConstructor>?
/// <interfaces>?
/// '{'
/// (<metadata> <viewMemberDeclaration>)*
/// '}'
///
/// <viewPrimaryConstructor> ::=
/// '(' <type> <identifier> ')'
///
/// <viewMemberDeclaration> ::=
/// <classMemberDefinition>
/// The token `view` is made a built-in identifier.
///
/// @description Checks that it is a compile-time error to declare a function
/// named `view`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that would actually not be an error. I've specified that view is a built-in identifier, which means that it would be an error to declare a type with that name, but other things (a function, a local variable, etc, anything-not-an-type) would be ok.

/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=extension-types

void view() {}
// ^^^^
// [analyzer] unspecified
// [cfe] unspecified

main() {
view();
}
37 changes: 37 additions & 0 deletions LanguageFeatures/Views/syntax_A01_t02.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion A rule for <viewDeclaration> is added to the grammar, along with
/// some rules for elements used in view declarations:
///
/// <viewDeclaration> ::=
/// 'view' 'class' <typeIdentifier> <typeParameters>?
/// <viewPrimaryConstructor>?
/// <interfaces>?
/// '{'
/// (<metadata> <viewMemberDeclaration>)*
/// '}'
///
/// <viewPrimaryConstructor> ::=
/// '(' <type> <identifier> ')'
///
/// <viewMemberDeclaration> ::=
/// <classMemberDefinition>
/// The token `view` is made a built-in identifier.
///
/// @description Checks that it is a compile-time error to declare a class
/// named `view`
/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=extension-types

class view {
// ^^^^
// [analyzer] unspecified
// [cfe] unspecified
}

main() {
view();
}
39 changes: 39 additions & 0 deletions LanguageFeatures/Views/syntax_A01_t03.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion A rule for <viewDeclaration> is added to the grammar, along with
/// some rules for elements used in view declarations:
///
/// <viewDeclaration> ::=
/// 'view' 'class' <typeIdentifier> <typeParameters>?
/// <viewPrimaryConstructor>?
/// <interfaces>?
/// '{'
/// (<metadata> <viewMemberDeclaration>)*
/// '}'
///
/// <viewPrimaryConstructor> ::=
/// '(' <type> <identifier> ')'
///
/// <viewMemberDeclaration> ::=
/// <classMemberDefinition>
/// The token `view` is made a built-in identifier.
///
/// @description Checks that it is a compile-time error to declare a mixin
/// named `view`
/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=extension-types

mixin view on Object {
// ^^^^
// [analyzer] unspecified
// [cfe] unspecified
}

class VA = Object with view;

main() {
VA();
}
34 changes: 34 additions & 0 deletions LanguageFeatures/Views/syntax_A01_t04.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion A rule for <viewDeclaration> is added to the grammar, along with
/// some rules for elements used in view declarations:
///
/// <viewDeclaration> ::=
/// 'view' 'class' <typeIdentifier> <typeParameters>?
/// <viewPrimaryConstructor>?
/// <interfaces>?
/// '{'
/// (<metadata> <viewMemberDeclaration>)*
/// '}'
///
/// <viewPrimaryConstructor> ::=
/// '(' <type> <identifier> ')'
///
/// <viewMemberDeclaration> ::=
/// <classMemberDefinition>
/// The token `view` is made a built-in identifier.
///
/// @description Checks that it is a compile-time error to declare a variable
/// named `view`
eernstg marked this conversation as resolved.
Show resolved Hide resolved
/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=extension-types

main() {
int view = 42;
// ^^^^
// [analyzer] unspecified
// [cfe] unspecified
}
41 changes: 41 additions & 0 deletions LanguageFeatures/Views/syntax_A01_t05.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion A rule for <viewDeclaration> is added to the grammar, along with
/// some rules for elements used in view declarations:
///
/// <viewDeclaration> ::=
/// 'view' 'class' <typeIdentifier> <typeParameters>?
/// <viewPrimaryConstructor>?
/// <interfaces>?
/// '{'
/// (<metadata> <viewMemberDeclaration>)*
/// '}'
///
/// <viewPrimaryConstructor> ::=
/// '(' <type> <identifier> ')'
///
/// <viewMemberDeclaration> ::=
/// <classMemberDefinition>
/// The token `view` is made a built-in identifier.
///
/// @description Checks that it is a compile-time error to declare a constant
/// named `view`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again not an error.

/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=extension-types

const view = 42;
// ^^^^
// [analyzer] unspecified
// [cfe] unspecified

@view class View {
final int id;
View(this.id);
}

main() {
View(0);
}
36 changes: 36 additions & 0 deletions LanguageFeatures/Views/syntax_A01_t06.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion A rule for <viewDeclaration> is added to the grammar, along with
/// some rules for elements used in view declarations:
///
/// <viewDeclaration> ::=
/// 'view' 'class' <typeIdentifier> <typeParameters>?
/// <viewPrimaryConstructor>?
/// <interfaces>?
/// '{'
/// (<metadata> <viewMemberDeclaration>)*
/// '}'
///
/// <viewPrimaryConstructor> ::=
/// '(' <type> <identifier> ')'
///
/// <viewMemberDeclaration> ::=
/// <classMemberDefinition>
/// The token `view` is made a built-in identifier.
///
/// @description Checks that it is a compile-time error import a library with
/// import prefix `view`
/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=extension-types

import "views_lib.dart" as view;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! A prefix is not a type, but it is indeed included among the things that can't have a name which is a built-in identifier. I forgot to mention that above.

// ^^^^
// [analyzer] unspecified
// [cfe] unspecified

main() {
view.x;
}
36 changes: 36 additions & 0 deletions LanguageFeatures/Views/syntax_A01_t07.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion A rule for <viewDeclaration> is added to the grammar, along with
/// some rules for elements used in view declarations:
///
/// <viewDeclaration> ::=
/// 'view' 'class' <typeIdentifier> <typeParameters>?
/// <viewPrimaryConstructor>?
/// <interfaces>?
/// '{'
/// (<metadata> <viewMemberDeclaration>)*
/// '}'
///
/// <viewPrimaryConstructor> ::=
/// '(' <type> <identifier> ')'
///
/// <viewMemberDeclaration> ::=
/// <classMemberDefinition>
/// The token `view` is made a built-in identifier.
///
/// @description Checks that it is a compile-time error to declare a type alias
/// named `view`
/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=extension-types

typedef view = String;
// ^^^^
// [analyzer] unspecified
// [cfe] unspecified

main() {
view s = "";
}
67 changes: 67 additions & 0 deletions LanguageFeatures/Views/syntax_A02_t01.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion A rule for <viewDeclaration> is added to the grammar, along with
/// some rules for elements used in view declarations:
///
/// <viewDeclaration> ::=
/// 'view' 'class' <typeIdentifier> <typeParameters>?
/// <viewPrimaryConstructor>?
/// <interfaces>?
/// '{'
/// (<metadata> <viewMemberDeclaration>)*
/// '}'
///
/// <viewPrimaryConstructor> ::=
/// '(' <type> <identifier> ')'
///
/// <viewMemberDeclaration> ::=
/// <classMemberDefinition>
/// ...
/// If a view declaration named View includes a <viewPrimaryConstructor> then it
/// is a compile-time error if the declaration includes a constructor
/// declaration named View. (But it can still contain other constructors.)
///
/// @description Checks that it is a compile-time error if a view declaration
/// named `View` includes a <viewPrimaryConstructor> and includes a constructor
/// named `View`
/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=extension-types

view class View1(int id) {
View1(this.id);
//^^^^^
// [analyzer] unspecified
// [cfe] unspecified
}

view class View2(int id) {
View2(int id, int x) {}
//^^^^^
// [analyzer] unspecified
// [cfe] unspecified
}

view class View3(int id) {
View3();
//^^^^^
// [analyzer] unspecified
// [cfe] unspecified
}

view class View4(int id) {
factory View4(int id) => View4.named(id);
// ^^^^^
// [analyzer] unspecified
// [cfe] unspecified
View4.named(int x) : id = x;
}

main() {
print(View1);
print(View2);
print(View3);
print(View4);
}
62 changes: 62 additions & 0 deletions LanguageFeatures/Views/syntax_A02_t02.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion A rule for <viewDeclaration> is added to the grammar, along with
/// some rules for elements used in view declarations:
///
/// <viewDeclaration> ::=
/// 'view' 'class' <typeIdentifier> <typeParameters>?
/// <viewPrimaryConstructor>?
/// <interfaces>?
/// '{'
/// (<metadata> <viewMemberDeclaration>)*
/// '}'
///
/// <viewPrimaryConstructor> ::=
/// '(' <type> <identifier> ')'
///
/// <viewMemberDeclaration> ::=
/// <classMemberDefinition>
/// ...
/// If a view declaration named View includes a <viewPrimaryConstructor> then it
/// is a compile-time error if the declaration includes a constructor
/// declaration named View. (But it can still contain other constructors.)
///
/// @description Checks that it is a compile-time error if a view declaration
/// named `View` includes a <viewPrimaryConstructor> with zero or more than one
/// parameters
/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=extension-types

view class View1() {
// ^^^^^
// [analyzer] unspecified
// [cfe] unspecified
}

view class View2(int id, String name) {
// ^
// [analyzer] unspecified
// [cfe] unspecified
}

view class View3(int id, {String name}) {
// ^
// [analyzer] unspecified
// [cfe] unspecified
}

view class View4(int id, [String name]) {
// ^
// [analyzer] unspecified
// [cfe] unspecified
}

main() {
print(View1);
print(View2);
print(View3);
print(View4);
}
Loading