Fixes #2344. Add more tests for constants #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 3, 2023
2023-11-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2344. Add more tests for constants (dart-lang/co19#2345) 2023-11-02 sgrekhov22@gmail.com dart-lang/co19#1400. Fix static_analysis_extension_types_A10_t03.dart (dart-lang/co19#2328) 2023-11-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.0 to 4.1.1 (dart-lang/co19#2343) 2023-11-01 sgrekhov22@gmail.com dart-lang/co19#1400. Add test that extension type and its representation type cannot be in the same constant collection (dart-lang/co19#2341) 2023-10-30 sgrekhov22@gmail.com Fixes dart-lang/co19#2335. Fix superinterfaces_of_extension_type_A05_t07.dart, add new test expecting an error (dart-lang/co19#2336) 2023-10-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2333. Representation type can be a subtype of a supertype (dart-lang/co19#2334) Change-Id: I8531cb4b0e8e3900514f8b0143f918e76f1b0290 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333780 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go on adding co19 regressions tests for issues discovered by @parlough