Fixes #2445. Add safety margin for Timer.periodic and check negative duration #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…negative duration
|
@sigmundch, it is my understanding that this test modification is well-understood today (based on similar transformations of other tests), so I landed the PR. If that was a bit too quick and you have further comments then please create a co19 repo issue, and then we can take another round. |
|
Thank you, lgtm! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Dec 28, 2023
2023-12-21 sgrekhov22@gmail.com dart-lang/co19#1400. Add the trivial case and a pattern check (dart-lang/co19#2451) 2023-12-21 sgrekhov22@gmail.com Fixes dart-lang/co19#2446. Update cast-pattern exhaustiveness tests according to the changed spec (dart-lang/co19#2448) 2023-12-20 sgrekhov22@gmail.com Fixes dart-lang/co19#2445. Add safety margin for Timer.periodic and check negative duration (dart-lang/co19#2447) 2023-12-19 sgrekhov22@gmail.com dart-lang/co19#2419. Add missing int ~/ double constants expression (dart-lang/co19#2444) 2023-12-19 sgrekhov22@gmail.com Fixes dart-lang/co19#2419. Add/update tests according to the recent spec changes (dart-lang/co19#2442) Change-Id: Ifbfc6c1f442ac236ce16770526991a6653b8041c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/343380 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Jonas Termansen <sortie@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.