Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.19] runZoned docs #4224

Closed
MaryaBelanger opened this issue Sep 14, 2022 · 7 comments · Fixed by #4403
Closed

[2.19] runZoned docs #4224

MaryaBelanger opened this issue Sep 14, 2022 · 7 comments · Fixed by #4403
Assignees
Labels
a.articles Relates to articles written on topics in Dart e1-hours Can complete in < 8 hours of normal, not dedicated, work e2-days Can complete in < 5 days of normal, not dedicated, work from.team Reported by Dash docs team member p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@MaryaBelanger
Copy link
Contributor

MaryaBelanger commented Sep 14, 2022

Parent:

dart-lang/sdk#49679

Evaluation:

  • Update needed:
  • No entry in change log yet, add
    • The only changes here are to the API docs, onError was already deprecated in a past release. I don't think cathcing up on API docs changes warrant an item in the change log
    • But still warrants mention in 'What's new' page

Reference:

@MaryaBelanger MaryaBelanger self-assigned this Sep 14, 2022
@parlough
Copy link
Member

parlough commented Sep 14, 2022

The zones article is heavily outdated, in both the code examples and some of the explanations with much of it predating Dart 2. It's definitely not idiomatic anymore. The writing and formatting of the website has heavily changed since then too.

Users want to learn more about zones though, so I would like to see the article updated. Starting with getting the code examples functional currently and then adjusting for the 2.19 changes when that comes around would be a good start.

@parlough parlough added p2-medium Necessary but not urgent concern. Resolve when possible. a.articles Relates to articles written on topics in Dart e1-hours Can complete in < 8 hours of normal, not dedicated, work e2-days Can complete in < 5 days of normal, not dedicated, work labels Sep 14, 2022
@parlough parlough added this to the Next stable release milestone Sep 14, 2022
@MaryaBelanger
Copy link
Contributor Author

@parlough So, this doesn't need to be rolled out with the 2.19 release, necessarily? It sounds like an improvement issue vs. a fix. Just want to clarify

@parlough
Copy link
Member

parlough commented Sep 14, 2022

The removal of onError from runZoned does require changes/fixes to the article with the 2.19 release.

I'm just highlighting other changes are needed to get the article compatible with even Dart 2.18 (hence the current archived state), so perhaps that's a higher priority, first step that should be completed first.

@MaryaBelanger
Copy link
Contributor Author

@parlough could you help me figure out where to view the changes made in this commit in api.dart.dev? I've found that lines 1696-1726 seem to correspond to here... but I can't find some of the other new stuff/changes. Eg, where do the examples between lines 624 and 668 show up in the API docs?

How can I learn to interpret API doc changes better going forward?

I'd like to see the new examples of runZonedGuarded rendered in the API docs (it's hard to assess what the samples look like in the diff :/)

Appreciate your time! 🙏

@parlough
Copy link
Member

It seems some of those changes might be on the properties of the Zone class itself. For example, lines 624 through 688 are on the errorZone property of the class.

It's sometimes bit hard to see, especially on Gerrit, but to find where doc changes are, I scroll down to find the class, property, or method they are attached to, then I search for that. For example when searching for errorZone, the first result is that Zone property. If there are multiple results, I scroll up to find the class the method or property is part of.

@MaryaBelanger
Copy link
Contributor Author

Small related fix in API docs: https://dart-review.googlesource.com/c/sdk/+/272488

atsansone added a commit that referenced this issue Dec 20, 2022
This page obviously needs a lot of work, so I didn't update any of the
conceptual content or any other dart syntax stuff _except_ what is
directly related to changing the examples to using `runZonedGuarded`.

Full page update is tracked here:
#4348

Closes #4224

Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@MaryaBelanger
Copy link
Contributor Author

Fixing PRs merged into v2.19

parlough added a commit that referenced this issue Jan 23, 2023
This page obviously needs a lot of work, so I didn't update any of the
conceptual content or any other dart syntax stuff _except_ what is
directly related to changing the examples to using `runZonedGuarded`.

Full page update is tracked here:
#4348

Closes #4224

Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
parlough added a commit that referenced this issue Jan 23, 2023
This page obviously needs a lot of work, so I didn't update any of the
conceptual content or any other dart syntax stuff _except_ what is
directly related to changing the examples to using `runZonedGuarded`.

Full page update is tracked here:
#4348

Closes #4224

Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
parlough added a commit that referenced this issue Jan 24, 2023
This page obviously needs a lot of work, so I didn't update any of the
conceptual content or any other dart syntax stuff _except_ what is
directly related to changing the examples to using `runZonedGuarded`.

Full page update is tracked here:
#4348

Closes #4224

Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
parlough added a commit that referenced this issue Jan 24, 2023
This page obviously needs a lot of work, so I didn't update any of the
conceptual content or any other dart syntax stuff _except_ what is
directly related to changing the examples to using `runZonedGuarded`.

Full page update is tracked here:
#4348

Closes #4224

Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@atsansone atsansone added the from.team Reported by Dash docs team member label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.articles Relates to articles written on topics in Dart e1-hours Can complete in < 8 hours of normal, not dedicated, work e2-days Can complete in < 5 days of normal, not dedicated, work from.team Reported by Dash docs team member p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants