-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.19] runZoned docs #4224
Comments
The zones article is heavily outdated, in both the code examples and some of the explanations with much of it predating Dart 2. It's definitely not idiomatic anymore. The writing and formatting of the website has heavily changed since then too. Users want to learn more about zones though, so I would like to see the article updated. Starting with getting the code examples functional currently and then adjusting for the 2.19 changes when that comes around would be a good start. |
@parlough So, this doesn't need to be rolled out with the 2.19 release, necessarily? It sounds like an improvement issue vs. a fix. Just want to clarify |
The removal of I'm just highlighting other changes are needed to get the article compatible with even Dart 2.18 (hence the current archived state), so perhaps that's a higher priority, first step that should be completed first. |
@parlough could you help me figure out where to view the changes made in this commit in api.dart.dev? I've found that lines 1696-1726 seem to correspond to here... but I can't find some of the other new stuff/changes. Eg, where do the examples between lines 624 and 668 show up in the API docs? How can I learn to interpret API doc changes better going forward? I'd like to see the new examples of Appreciate your time! 🙏 |
It seems some of those changes might be on the properties of the It's sometimes bit hard to see, especially on Gerrit, but to find where doc changes are, I scroll down to find the class, property, or method they are attached to, then I search for that. For example when searching for |
Small related fix in API docs: https://dart-review.googlesource.com/c/sdk/+/272488 |
This page obviously needs a lot of work, so I didn't update any of the conceptual content or any other dart syntax stuff _except_ what is directly related to changing the examples to using `runZonedGuarded`. Full page update is tracked here: #4348 Closes #4224 Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>
Fixing PRs merged into v2.19 |
This page obviously needs a lot of work, so I didn't update any of the conceptual content or any other dart syntax stuff _except_ what is directly related to changing the examples to using `runZonedGuarded`. Full page update is tracked here: #4348 Closes #4224 Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>
This page obviously needs a lot of work, so I didn't update any of the conceptual content or any other dart syntax stuff _except_ what is directly related to changing the examples to using `runZonedGuarded`. Full page update is tracked here: #4348 Closes #4224 Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>
This page obviously needs a lot of work, so I didn't update any of the conceptual content or any other dart syntax stuff _except_ what is directly related to changing the examples to using `runZonedGuarded`. Full page update is tracked here: #4348 Closes #4224 Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>
This page obviously needs a lot of work, so I didn't update any of the conceptual content or any other dart syntax stuff _except_ what is directly related to changing the examples to using `runZonedGuarded`. Full page update is tracked here: #4348 Closes #4224 Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>
Parent:
dart-lang/sdk#49679
Evaluation:
runZoned
withonError
usedPage is archived, what's the policy there? Update and take out of archive?No entry in change log yet, addonError
was already deprecated in a past release. I don't think cathcing up on API docs changes warrant an item in the change logReference:
runZoned
withonError
torunZoned
andrunZonedGuarded
runZonedGuarded
in use:(error, stackTrace)
example(dynamic error, StackTrace stackTrace)
exampleThe text was updated successfully, but these errors were encountered: