Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 2.19 entry to the "What's new" page #4542

Merged
merged 12 commits into from
Jan 25, 2023
Merged

Conversation

MaryaBelanger
Copy link
Contributor

@MaryaBelanger MaryaBelanger commented Jan 24, 2023

Adds the 2.19 entry to the "What's new" page.

Fixes #4404

@MaryaBelanger
Copy link
Contributor Author

Might have one more "what's new" entry if #4528 is ready in time

@parlough parlough self-requested a review January 24, 2023 04:37
@parlough parlough marked this pull request as draft January 24, 2023 04:37
@parlough
Copy link
Member

parlough commented Jan 24, 2023

Thanks for working on this!

I’ll take a look early tomorrow. We can hold off on this one until the blog posts are released. I switched to draft to better signify that.

@MaryaBelanger
Copy link
Contributor Author

MaryaBelanger commented Jan 24, 2023

I thought I'd set it to draft 😅 thanks for catching that! Edit: I took it our of draft because my TODOs are done

We can hold off on this one until the blog posts are released.

So, the release blog post doesn't actually go out until the 25th. Idk if you want to wait that long. I could just remove that link until tomorrow.

I did just replace the author part of the draft urls (i.e. "mit-mit"/"mbelanger") with "dartlang", which is what they'll be once published, so at least they're not broken links

@MaryaBelanger
Copy link
Contributor Author

Hmm, maybe "What's new on dart.dev" is not the best new page title, since the first sentence says "This page describes what’s new on the Dart website and blog"... Thoughts?

@MaryaBelanger MaryaBelanger marked this pull request as ready for review January 24, 2023 15:22
@MaryaBelanger
Copy link
Contributor Author

About the language evolution page:
Since this page is just about language changes, should I skip mentioning things that are more... idk, package-related? I.e.:

  • package:js @staticinterop annotation?
  • pub changes?
  • Isolate.run?

@parlough
Copy link
Member

parlough commented Jan 24, 2023

So, the release blog post doesn't actually go out until the 25th. Idk if you want to wait that long. I could just remove that link until tomorrow.

I think it makes sense to keep "What's new" released on the same day as those, especially with all the blog links, but am happy to get in it today if you'd like. We've had mismatch before during 2.13 and that's what we did since there's no need to rush this page update.

Consider separating the language evolution changes to a new PR targeting the main branch (after fetching the latest changes there), as those would be nice to get in.

Hmm, maybe "What's new on dart.dev" is not the best new page title, since the first sentence says "This page describes what’s new on the Dart website and blog"... Thoughts?

I didn't consider that, thanks for pointing it out. I guess it's fine to stick to the old title since on the website we only link to it with context. I do get this as the first search result for "What's new in Dart" so it is a tad confusing, but we do link to the blog posts and changelog so it's probably okay.

Google results for 'what's new in dart'

Since this page is just about language changes, should I skip mentioning things that are more... idk, package-related? I.e.:

Yep! We should skip those pieces :) - We use the page for primarily pure language changes, outside of a few minor exceptions before.

@parlough parlough changed the base branch from v2.19 to main January 24, 2023 16:51
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really love both these additions! You were so thorough :D

src/_guides/language/evolution.md Outdated Show resolved Hide resolved
src/_guides/language/evolution.md Outdated Show resolved Hide resolved
src/_guides/language/evolution.md Outdated Show resolved Hide resolved
src/_guides/whats-new.md Outdated Show resolved Hide resolved
src/_guides/whats-new.md Outdated Show resolved Hide resolved
src/_guides/whats-new.md Show resolved Hide resolved
src/_guides/whats-new.md Outdated Show resolved Hide resolved
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@MaryaBelanger
Copy link
Contributor Author

I do get this as the first search result for "What's new in Dart" so it is a tad confusing,

Oh I definitely still think the name should change, more so now that you've pointed that out. I just meant "...on dart.dev" doesn't make sense, so maybe "What's new in Dart documentation" or "What's new in Dart docs"? Just a question of sound/feel (better ideas welcome 😅 )

src/_guides/whats-new.md Outdated Show resolved Hide resolved
src/_guides/whats-new.md Outdated Show resolved Hide resolved
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@github-actions
Copy link

github-actions bot commented Jan 24, 2023

Visit the preview URL for this PR (updated for commit 4bb4a32):

https://dart-dev--pr4542-whats-new-language-e-o6qj0j4b.web.app

(expires Wed, 01 Feb 2023 17:37:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

@parlough parlough added the review.copy Awaiting Copy Review label Jan 24, 2023
@MaryaBelanger MaryaBelanger changed the title [2.19] What's new and language evolution [2.19] What's new Jan 24, 2023
Copy link
Collaborator

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, a very impressive list! Especially given that this was all after Kathy resigned. lgtm

@parlough
Copy link
Member

Thanks for the review @sfshaza2. Marya did a great job with this list and release :)

@parlough parlough removed the review.copy Awaiting Copy Review label Jan 24, 2023
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final comments/suggestions then looks good to me. Thanks @MaryaBelanger!

src/_guides/whats-new.md Outdated Show resolved Hide resolved
src/_guides/whats-new.md Outdated Show resolved Hide resolved
src/_guides/whats-new.md Outdated Show resolved Hide resolved
src/_guides/whats-new.md Outdated Show resolved Hide resolved
src/_guides/index.md Outdated Show resolved Hide resolved
src/_guides/index.md Outdated Show resolved Hide resolved
MaryaBelanger and others added 2 commits January 25, 2023 09:27
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@parlough parlough changed the title [2.19] What's new Add the 2.19 entry to the "What's new" page Jan 25, 2023
@parlough parlough merged commit 27bbcf1 into main Jan 25, 2023
@parlough parlough deleted the whats-new/language-evo branch January 25, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.19] Update whats-new and language evolution pages
3 participants