New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't collect coverage on Windows #276

Merged

kevmoo merged 1 commit into main from kevmoo-patch-1

Jun 24, 2024

Member

kevmoo commented Jun 21, 2024

it's been failing forever


          Don't collect coverage on Windows

9108b46

it's been failing forever

kevmoo requested a review from dcharkes

June 21, 2024 22:39

github-actions bot added the type-infra label

coveralls commented Jun 21, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 9620608710

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 9432547518:	0.0%
Covered Lines:	252
Relevant Lines:	252

💛 - Coveralls

Member

devoncarew commented Jun 21, 2024

dcharkes approved these changes

View reviewed changes

kevmoo merged commit e660a68 into main

8 checks passed

kevmoo deleted the kevmoo-patch-1 branch

June 24, 2024 15:26

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request


          [deps] rev csslib, dartdoc, http, pool, pub_semver, string_scanner, t…

87ca13f

…est_descriptor, test_process, tools, typed_data, webdev, yaml

Revisions updated by `dart tools/rev_sdk_deps.dart`.

csslib (https://github.com/dart-lang/csslib/compare/23c314b..b70fef2):
  b70fef2  2024-06-20  Kevin Moore  Update and fix lints, bump min SDK to Dart 3.1 (dart-lang/csslib#204)

dartdoc (https://github.com/dart-lang/dartdoc/compare/6330a13..88df88c):
  88df88c9  2024-06-21  Sam Rawlins  Remove the unnecessary Privacy mixin (dart-lang/dartdoc#3794)
  d050cb44  2024-06-20  Sam Rawlins  Make PackageGraph.allLibraries private (dart-lang/dartdoc#3792)
  7c559d41  2024-06-20  Sam Rawlins  Simplify Library.allModelElements (dart-lang/dartdoc#3793)

http (https://github.com/dart-lang/http/compare/8c325b9..4d8e7ef):
  4d8e7ef  2024-06-24  Brian Quinlan  Add a note saying that we only create a single `Client`. (dart-lang/http#1234)

pool (https://github.com/dart-lang/pool/compare/88e4636..832c5ab):
  832c5ab  2024-06-21  Kevin Moore  update lints, require Dart 3.4 (dart-lang/pool#89)
  d107269  2024-06-20  Kevin Moore  blast_repo fixes (dart-lang/pool#88)

pub_semver (https://github.com/dart-lang/pub_semver/compare/a9025f3..dfcad38):
  dfcad38  2024-06-20  Kevin Moore  bump lints and SDK dep, test wasm (dart-lang/pub_semver#105)

string_scanner (https://github.com/dart-lang/string_scanner/compare/7b37c1b..e1cab8f):
  e1cab8f  2024-06-20  Kevin Moore  update lints, require Dart 3.1 (dart-lang/string_scanner#76)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/b23d7cc..2f19400):
  2f19400  2024-06-20  Kevin Moore  update lints (dart-lang/test_descriptor#68)

test_process (https://github.com/dart-lang/test_process/compare/862eaf3..a7ca20b):
  a7ca20b  2024-06-21  Kevin Moore  update lints (dart-lang/test_process#60)

tools (https://github.com/dart-lang/tools/compare/4321aec..e660a68):
  e660a68  2024-06-24  Kevin Moore  Don't collect coverage on Windows (dart-lang/tools#276)

typed_data (https://github.com/dart-lang/typed_data/compare/d14f965..8529929):
  8529929  2024-06-21  Kevin Moore  update lints, require Dart 3.1 (dart-lang/typed_data#90)
  c90e624  2024-06-20  Kevin Moore  blast_repo fixes (dart-lang/typed_data#89)

webdev (https://github.com/dart-lang/webdev/compare/eccc7d8..c566112):
  c5661125  2024-06-24  Kevin Moore  Drop use of deprecated APIs, bump min SDK and other dependencies (dart-lang/webdev#2449)

yaml (https://github.com/dart-lang/yaml/compare/7873b3f..4cf24ca):
  4cf24ca  2024-06-20  Kevin Moore  update lints, require Dart 3.4 (dart-lang/yaml#167)
  7018ac8  2024-06-20  Kevin Moore  blast_repo fixes (dart-lang/yaml#166)

Change-Id: I04c6238514cb46818c3f59760e401d371e4d1ae4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372841
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels