Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix!: invalid JSON RPC internal error code #271

Merged
merged 1 commit into from
May 29, 2020

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented May 29, 2020

Issue being fixed or feature implemented

Updated return error code according to a spec here

What was done?

Updated return error code to a -32603 for internal errors

How Has This Been Tested?

Tested using running mn-bootstrap using custom pre-built dapi image. And checking error code returned by the dapi-client

Breaking Changes

Error code for internal errors now -32603, as per spec.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title fix: JsonRPC internal error code fix: invalid JSON RPC internal error code May 29, 2020
@jawid-h jawid-h added this to the v0.13 milestone May 29, 2020
@jawid-h jawid-h changed the title fix: invalid JSON RPC internal error code fix!: invalid JSON RPC internal error code May 29, 2020
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@shumkov shumkov merged commit dd0a09e into v0.13-dev May 29, 2020
@shumkov shumkov deleted the fix-internal-error-code branch May 29, 2020 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants