Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: сallback was already called #46

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix: сallback was already called #46

merged 1 commit into from
Jul 5, 2022

Conversation

strophy
Copy link
Contributor

@strophy strophy commented Jul 5, 2022

Smoke tests were returning errors in CI:

Error: Callback was already called.
    at /usr/src/app/node_modules/async/dist/async.js:321:36
    at newCallback (/usr/src/app/node_modules/@dashevo/dashd-rpc/lib/index.js:59:7)
    at ClientRequest.<anonymous> (/usr/src/app/node_modules/@dashevo/dashd-rpc/lib/index.js:146:7)
    ...

Use of the debugger revealed information about the request/response sent in the first callback function, and timeout messages being sent to the callback function in a second run. This PR fixes it, although I'm not entirely sure if this is how the called variable is supposed to be used.

@strophy strophy requested a review from shumkov July 5, 2022 12:45
@shumkov shumkov changed the title fix: Callback was already called fix: сallback was already called Jul 5, 2022
shumkov
shumkov approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@strophy strophy merged commit 3b68108 into master Jul 5, 2022
@strophy strophy deleted the fix/callback branch July 5, 2022 13:10
@Mhmonicox Mhmonicox mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strophy @shumkov