UCR Support #15
UCR Support #15
Conversation
| // } | ||
| // CloseableHttpResponse response = client.execute(put); | ||
| // getLog().info("Response from DC/OS [" + response.getStatusLine().getStatusCode() + "] " + IOUtils.toString(response.getEntity().getContent(), "UTF-8")); | ||
|
|
There was a problem hiding this comment.
Why removing this code block? Am I missing something?
| String nexusPassword; | ||
|
|
||
|
|
||
| @Parameter(defaultValue = "${project.basedir}/.dcos-token", property = "dcosTokenFile", required = true) |
There was a problem hiding this comment.
Please indent line 31 to 40 to two spaces.
|
|
||
| getLog().info(project.getArtifact().getFile().toString()); | ||
|
|
||
| Process p = Runtime.getRuntime().exec("curl -u " + nexusUser + ":" + nexusPassword +" --upload-file "+ project.getArtifact().getFile().toString() + " http://" + nexusUrl + "/repository/" + nexusRepositoryName + "/");//file.toString()); |
There was a problem hiding this comment.
Ok, I`ll have a look at this tomorrow. Nice hack btw ;P
In this process world, I would call p.exitCode to make sure this process finished.
| throw new RuntimeException("Artifact does not exist. Did you run mvn package dcos:pushArtifact?"); | ||
| } | ||
|
|
||
| tmpPath = File.createTempFile("ucr-deploy", "json").toPath(); |
There was a problem hiding this comment.
@joerg84 I changed this to work in os tmp directory, hope this is ok for you.
|
|
||
| getLog().info("Uploading this file: " + file.toString()); | ||
|
|
||
| HttpPut put = new HttpPut("http://" + nexusUrl + "/repository/" + nexusRepositoryName + "/" + file.getName()); |
There was a problem hiding this comment.
file.getName() was missing here. curl --upload-file adds the filename to the url.
There was a problem hiding this comment.
Shouldn't the <nexusUrl> parameter also be including the protocol? Hardcoding it to http seems a bit weak?
There was a problem hiding this comment.
yep, sounds good. Maybe it would be possible to do things like:
if nexusUrl includes protocol, use it, use http as fallback otherwise? Are you fancy providing a small patch or is @joerg84 willing to update the implementation? ❤️
|
Thank you, you rock! 🤘 |
No description provided.