Skip to content

Commit

Permalink
fix(gitreceive): fix checkForEnv logic
Browse files Browse the repository at this point in the history
val != val is clearly never going to fail. Changed
to expVal != val
  • Loading branch information
lshemesh committed Mar 29, 2017
1 parent 4634fe1 commit 56abf92
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/gitreceive/k8s_util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ func checkForEnv(t *testing.T, pod *api.Pod, key, expVal string) {
if err != nil {
t.Errorf("%v", err)
}
if val != val {
if expVal != val {
t.Errorf("expected %v but returned %v ", expVal, val)
}
}
Expand Down

0 comments on commit 56abf92

Please sign in to comment.