Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethpy transaction hotfixes #1079

Merged
merged 9 commits into from
Nov 9, 2023
Merged

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Nov 9, 2023

  1. Adding in custom non-async wait for transaction function that implements exponential backoff.
  2. Transactions sometimes don't return logs (e.g., the checkpoint call), so don't throw an error when no logs are found.
  3. Redeem withdrawal shares with an invalid amount is a valid contract call, so we explicitly check for zero values in the preview call on our side and throw an error if we detect this case
  4. Adding test that goes through invalid trades

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 10:50pm

@slundqui slundqui merged commit 40af1cf into delvtech:main Nov 9, 2023
6 checks passed
@slundqui slundqui deleted the checkpoint_bot_fix branch November 9, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants