Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle events in ethpy #1571

Merged
merged 12 commits into from
Jun 27, 2024
Merged

Handle events in ethpy #1571

merged 12 commits into from
Jun 27, 2024

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Jun 27, 2024

This PR is part of the consolidation effort to bring all event getters to ethpy. Overall, this allows us to handle specific interfaces (e.g., steth) in a single place.

  • Move event classes from agent0 interface to ethpy interface, and have ethpy trade calls return the event object.
  • Move all event getters to the ethpy interface.

@slundqui slundqui marked this pull request as draft June 27, 2024 00:03
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 97.90576% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (dab10b2) to head (94acf50).
Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
src/agent0/ethpy/hyperdrive/transactions.py 95.65% 2 Missing ⚠️
src/agent0/chainsync/db/hyperdrive/convert_data.py 0.00% 1 Missing ⚠️
src/agent0/ethpy/base/transactions.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
+ Coverage   81.55%   82.39%   +0.84%     
==========================================
  Files          98       98              
  Lines        7163     7164       +1     
==========================================
+ Hits         5842     5903      +61     
+ Misses       1321     1261      -60     
Flag Coverage Δ
unittests 82.39% <97.90%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui changed the title Moving event definitions into ethpy Handle events in ethpy Jun 27, 2024
@slundqui slundqui marked this pull request as ready for review June 27, 2024 00:35
@slundqui slundqui mentioned this pull request Jun 27, 2024
3 tasks
@slundqui slundqui merged commit dcbfd8d into delvtech:main Jun 27, 2024
4 checks passed
@slundqui slundqui deleted the ethpy-events branch June 27, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants