Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing of block identifiers (e.g., "pending") to interface functions. #1602

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

slundqui
Copy link
Contributor

Additionally allows interface.get_hyperdrive_state() to get a block_identifier instead of the block data. Still allows passing in of an explicit block_data parameter if the caller has this information.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.41%. Comparing base (9ccfd4d) to head (5caf18e).

Files Patch % Lines
...gent0/ethpy/hyperdrive/interface/read_interface.py 92.10% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1602      +/-   ##
==========================================
+ Coverage   81.14%   81.41%   +0.27%     
==========================================
  Files          98       98              
  Lines        7275     7276       +1     
==========================================
+ Hits         5903     5924      +21     
+ Misses       1372     1352      -20     
Flag Coverage Δ
unittests 81.41% <94.11%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui enabled auto-merge (squash) July 11, 2024 22:33
@slundqui slundqui merged commit 9e2772a into delvtech:main Jul 11, 2024
4 checks passed
@slundqui slundqui deleted the lp-share-price-fix branch July 11, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants