Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System tests #837

Merged
merged 32 commits into from
Aug 17, 2023
Merged

System tests #837

merged 32 commits into from
Aug 17, 2023

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Aug 17, 2023

This PR adds the first system test for elf-simulations.

Major changes:

  • It's here! Adds a system test that runs from bots to postgres db on a local test chain.
  • Adding custom bot for test fixtures that cycles through all trades with known amounts
  • Moving acquire_data.py to be within chainsync package, and writing minimal entry point to call
    • Breaking change: data capture script renamed from acquire_data.py to run_chainsync.py
  • Parameterizing acquire_data.py to allow for system tests
  • Explicitly setting a precision and scale for the Numeric postgres type

Minor changes:

  • Adding script for making vscode debugging pytest easier
  • Moving helper function get_web3_and_contracts from agent0 to ethpy
  • Adding coerce_float to all postgres getter functions
  • Docstrings
  • Formatting

Bug fixes:

  • Fixed a bug that stores invTimeStretch as unscaled values
  • Fixed a bug with postgres/python schema typing for maturityTime

TODO:

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 7:41pm

Copy link
Member

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! Everything is really coming together :)

@slundqui slundqui merged commit c296062 into delvtech:main Aug 17, 2023
4 checks passed
@slundqui slundqui deleted the system_test branch August 17, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants