-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Python types for all internal Solidity contract types. #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dpaiton
reviewed
Aug 22, 2023
dpaiton
reviewed
Aug 22, 2023
dpaiton
reviewed
Aug 22, 2023
dpaiton
reviewed
Aug 22, 2023
dpaiton
reviewed
Aug 22, 2023
dpaiton
reviewed
Aug 22, 2023
dpaiton
reviewed
Aug 22, 2023
dpaiton
reviewed
Aug 22, 2023
dpaiton
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few typos & such, otherwise good
sentilesdal
force-pushed
the
matt-add-tests
branch
from
August 23, 2023 17:37
d4abcda
to
97d0155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not the best commits, but not the worst. Probably best to look at the total files.
This PR creates a new file like IHyperdriveTypes.py that has all the internal types of a contract. There are also improvements to the formatting of the function parameters. I've also added a very basic test for the contract jinja template. This will be mostly replaced with better testing that uses a custom abi that i'll create to make sure we are testing all the crazy structs / nested tuples etc that we'll see returned from a contract. Next steps will be to add output types to all functions and then events!
Example output:
IHyperdriveTypes.py
Example contracts output now:
IHyperdriveContract.py