Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamlit performance optimizations #880

Merged
merged 10 commits into from
Sep 21, 2023
Merged

Streamlit performance optimizations #880

merged 10 commits into from
Sep 21, 2023

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Sep 20, 2023 •
edited
Loading

Adjusting streamlit to be more performant under high volume.

  • Reducing dashboard view from 14400 blocks to 5000 blocks
  • Moving groupby computation for positions over time to be on the sql side instead of pandas side in streamlit
  • Shortening loopback limit so acquire_data doesn't break when chain spins faster than data pipeline
  • Smaller fig sizes for faster plotting
  • Explicit figure closing and garbage collection
  • Removing warning printing on data collection from web3 for performance

Overall, there is still a memory leak, with a description, fixed within infra, and suggestions on longer term fixed detailed here: (#891)

@vercel
Copy link

vercel bot commented Sep 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 4:36pm

@slundqui slundqui changed the title Streamlit memory hotfix Streamlit performance optimizations Sep 20, 2023
@slundqui slundqui marked this pull request as draft September 20, 2023 17:01
@slundqui slundqui mentioned this pull request Sep 21, 2023
Open
@slundqui slundqui marked this pull request as ready for review September 21, 2023 01:59
@slundqui slundqui mentioned this pull request Sep 21, 2023
Closed
dpaiton
dpaiton approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really solid code improvements!

@slundqui slundqui merged commit 2bc29af into delvtech:main Sep 21, 2023
6 checks passed
@slundqui slundqui deleted the streamlit_memory_hotfix branch September 21, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpaiton dpaiton dpaiton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slundqui @dpaiton