Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aes128gcm encryption to Node compatibility layer #20353

Closed
MiguelRipoll23 opened this issue Sep 1, 2023 · 2 comments
Closed

Add aes128gcm encryption to Node compatibility layer #20353

MiguelRipoll23 opened this issue Sep 1, 2023 · 2 comments

Comments

@MiguelRipoll23
Copy link

MiguelRipoll23 commented Sep 1, 2023 •
edited
Loading

Continuation of #19002.

When using the module web-push from npm, calling the function sendNotification will result in an unknown cipher error in Deno v1.36.4

Thanks.
@MiguelRipoll23 MiguelRipoll23 changed the title Add prime256v1 cipher to Node compatibility layer Add aes128gcm encryption to Node compatibility layer Sep 1, 2023
This was referenced Sep 2, 2023
Closed
Merged
littledivy added a commit that referenced this issue Sep 6, 2023
@littledivy
fix(ext/node): implement AES GCM cipher (#20368)
9befa56 
Adds support for AES-GCM 128/256 bit keys in `node:crypto` and
`setAAD()`, `setAuthTag()` and `getAuthTag()`

Uses https://github.com/littledivy/aead-gcm-stream

Fixes #19836
#20353
@littledivy
Copy link
Member

Implemented in #20368

@MiguelRipoll23
Copy link
Author

Thank you!

bartlomieju pushed a commit to bartlomieju/deno that referenced this issue Sep 8, 2023
@littledivy @bartlomieju
fix(ext/node): implement AES GCM cipher (denoland#20368)
b56ca2e 
Adds support for AES-GCM 128/256 bit keys in `node:crypto` and
`setAAD()`, `setAuthTag()` and `getAuthTag()`

Uses https://github.com/littledivy/aead-gcm-stream

Fixes denoland#19836
denoland#20353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MiguelRipoll23 @littledivy