Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracking: use primordials in Node compatibility layer #24236

Open
iuioiua opened this issue Jun 17, 2024 · 0 comments
Open

tracking: use primordials in Node compatibility layer #24236

iuioiua opened this issue Jun 17, 2024 · 0 comments
Labels
good first issue Good for newcomers node compat

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Jun 17, 2024 •
edited
Loading

Remaining files:

  • fix(ext/node): use primordials in ext/node/polyfills/_utils.ts #24253
  • fix(ext/node): use primordials in ext/node/polyfills/_brotli.js #24235
  • fix(ext/node): use primordials in ext/node/polyfills/_http_common.ts #24281
  • fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_cp.js #24320
  • fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_dir.ts #24319
  • ext/node/polyfills/_fs/_fs_lstat.ts
  • ext/node/polyfills/_fs/_fs_opendir.ts
  • ext/node/polyfills/_fs/_fs_readv.ts
  • ext/node/polyfills/_fs/_fs_realpath.ts
  • ext/node/polyfills/_fs/_fs_mkdtemp.ts
  • ext/node/polyfills/_fs/_fs_readFile.ts
  • ext/node/polyfills/_fs/_fs_open.ts
  • ext/node/polyfills/_fs/_fs_readdir.ts
  • ext/node/polyfills/_fs/_fs_watch.ts
  • ext/node/polyfills/_fs/_fs_stat.ts
  • ext/node/polyfills/_fs/_fs_common.ts
  • ext/node/polyfills/_fs/_fs_fstat.ts
  • ext/node/polyfills/_fs/_fs_read.ts
  • ext/node/polyfills/_fs/_fs_unlink.ts
  • ext/node/polyfills/_fs/_fs_write.mjs
  • ext/node/polyfills/_fs/_fs_utimes.ts
  • ext/node/polyfills/_fs/_fs_fdatasync.ts
  • ext/node/polyfills/_fs/_fs_mkdir.ts
  • ext/node/polyfills/_fs/_fs_rmdir.ts
  • ext/node/polyfills/_fs/_fs_link.ts
  • ext/node/polyfills/_fs/_fs_writev.mjs
  • ext/node/polyfills/_fs/_fs_chown.ts
  • ext/node/polyfills/_fs/_fs_readlink.ts
  • ext/node/polyfills/_fs/_fs_futimes.ts
  • ext/node/polyfills/_fs/_fs_rm.ts
  • ext/node/polyfills/_fs/_fs_writeFile.ts
  • ext/node/polyfills/_fs/_fs_access.ts
  • ext/node/polyfills/_fs/_fs_chmod.ts
  • ext/node/polyfills/_fs/_fs_close.ts
  • ext/node/polyfills/_fs/_fs_ftruncate.ts
  • ext/node/polyfills/_fs/_fs_exists.ts
  • ext/node/polyfills/_fs/_fs_symlink.ts
  • ext/node/polyfills/_fs/_fs_rename.ts
  • ext/node/polyfills/_fs/_fs_truncate.ts
  • ext/node/polyfills/_fs/_fs_fsync.ts
  • ext/node/polyfills/_fs/_fs_copy.ts
  • fix(ext/node): use primordials in ext/node/polyfills/_process/ #24282
  • fix(ext/node): use primordials in ext/node/polyfills/string_decoder.ts #24296
  • fix(ext/node): use primordials in ext/node/polyfills/testing.ts #24310
  • fix(ext/node): use primordials in ext/node/polyfills/timers.ts #24311
  • ext/node/polyfills/_http_outgoing.ts
  • ext/node/polyfills/async_hooks.ts
  • ext/node/polyfills/process.ts
  • ext/node/polyfills/assertion_error.ts
  • ext/node/polyfills/path/_posix.ts
  • ext/node/polyfills/path/_util.ts
  • ext/node/polyfills/path/common.ts
  • ext/node/polyfills/path/_win32.ts
  • ext/node/polyfills/path/separator.ts
  • ext/node/polyfills/http.ts
  • ext/node/polyfills/stream/consumers.mjs
  • ext/node/polyfills/readline/promises.ts
  • ext/node/polyfills/internal/crypto/_randomInt.ts
  • ext/node/polyfills/internal/crypto/diffiehellman.ts
  • ext/node/polyfills/internal/crypto/hkdf.ts
  • ext/node/polyfills/internal/crypto/_keys.ts
  • ext/node/polyfills/internal/crypto/cipher.ts
  • ext/node/polyfills/internal/crypto/hash.ts
  • ext/node/polyfills/internal/crypto/pbkdf2.ts
  • ext/node/polyfills/internal/crypto/scrypt.ts
  • ext/node/polyfills/internal/crypto/random.ts
  • ext/node/polyfills/internal/crypto/_randomFill.mjs
  • ext/node/polyfills/internal/crypto/keys.ts
  • ext/node/polyfills/internal/crypto/constants.ts
  • ext/node/polyfills/internal/crypto/sig.ts
  • ext/node/polyfills/internal/crypto/_randomBytes.ts
  • ext/node/polyfills/internal/crypto/util.ts
  • ext/node/polyfills/internal/crypto/x509.ts
  • ext/node/polyfills/internal/validators.mjs
  • ext/node/polyfills/internal/querystring.ts
  • ext/node/polyfills/internal/util/debuglog.ts
  • ext/node/polyfills/internal/util/inspect.mjs
  • ext/node/polyfills/internal/errors.ts
  • ext/node/polyfills/internal/buffer.mjs
  • ext/node/polyfills/internal/async_hooks.ts
  • ext/node/polyfills/internal/http.ts
  • ext/node/polyfills/internal/readline/promises.mjs
  • ext/node/polyfills/internal/readline/utils.mjs
  • ext/node/polyfills/internal/readline/emitKeypressEvents.mjs
  • ext/node/polyfills/internal/readline/interface.mjs
  • ext/node/polyfills/internal/readline/symbols.mjs
  • ext/node/polyfills/internal/readline/callbacks.mjs
  • ext/node/polyfills/internal/util.mjs
  • ext/node/polyfills/internal/stream_base_commons.ts
  • ext/node/polyfills/internal/url.ts
  • ext/node/polyfills/internal/child_process.ts
  • ext/node/polyfills/internal/fixed_queue.ts
  • ext/node/polyfills/internal/net.ts
  • ext/node/polyfills/internal/hide_stack_frames.ts
  • ext/node/polyfills/internal/cli_table.ts
  • ext/node/polyfills/internal/primordials.mjs
  • ext/node/polyfills/internal/dgram.ts
  • ext/node/polyfills/internal/dns/utils.ts
  • ext/node/polyfills/internal/dns/promises.ts
  • ext/node/polyfills/internal/fs/utils.mjs
  • ext/node/polyfills/internal/fs/handle.ts
  • ext/node/polyfills/internal/fs/streams.mjs
  • ext/node/polyfills/internal/event_target.mjs
  • ext/node/polyfills/internal/timers.mjs
  • ext/node/polyfills/internal/normalize_encoding.mjs
  • ext/node/polyfills/internal/options.ts
  • ext/node/polyfills/internal/process/per_thread.mjs
  • ext/node/polyfills/internal/console/constructor.mjs
  • ext/node/polyfills/internal/idna.ts
  • ext/node/polyfills/v8.ts
  • ext/node/polyfills/crypto.ts
  • ext/node/polyfills/wasi.ts
  • ext/node/polyfills/diagnostics_channel.js
  • ext/node/polyfills/tls.ts
  • ext/node/polyfills/url.ts
  • ext/node/polyfills/child_process.ts
  • ext/node/polyfills/querystring.js
  • ext/node/polyfills/http2.ts
  • ext/node/polyfills/inspector.ts
  • ext/node/polyfills/os.ts
  • ext/node/polyfills/_next_tick.ts
  • ext/node/polyfills/net.ts
  • ext/node/polyfills/_readline.mjs
  • ext/node/polyfills/dgram.ts
  • ext/node/polyfills/https.ts
  • ext/node/polyfills/_http_agent.mjs
  • ext/node/polyfills/dns.ts
  • fix(ext/node): use primordials in ext/node/polyfills/console.ts #25572
  • ext/node/polyfills/_events.mjs
  • ext/node/polyfills/perf_hooks.ts
  • ext/node/polyfills/internal_binding/udp_wrap.ts
  • ext/node/polyfills/internal_binding/_utils.ts
  • ext/node/polyfills/internal_binding/mod.ts
  • ext/node/polyfills/internal_binding/tcp_wrap.ts
  • ext/node/polyfills/internal_binding/handle_wrap.ts
  • ext/node/polyfills/internal_binding/uv.ts
  • ext/node/polyfills/internal_binding/buffer.ts
  • ext/node/polyfills/internal_binding/symbols.ts
  • ext/node/polyfills/internal_binding/_timingSafeEqual.ts
  • ext/node/polyfills/internal_binding/async_wrap.ts
  • ext/node/polyfills/internal_binding/pipe_wrap.ts
  • ext/node/polyfills/internal_binding/util.ts
  • ext/node/polyfills/internal_binding/cares_wrap.ts
  • ext/node/polyfills/internal_binding/stream_wrap.ts
  • ext/node/polyfills/internal_binding/_listen.ts
  • ext/node/polyfills/internal_binding/node_options.ts
  • ext/node/polyfills/internal_binding/node_file.ts
This was referenced Jun 18, 2024
Merged
Merged
Merged
Merged
iuioiua added a commit that referenced this issue Jun 20, 2024
@iuioiua
fix(ext/node): use primordials in ext/node/polyfills/_brotli.js (#2…
6ab1433 
…4235)

Towards #24236
This was referenced Jun 21, 2024
Merged
Merged
Merged
Merged
Merged
iuioiua added a commit that referenced this issue Jun 24, 2024
@iuioiua
fix(ext/node): use primordials in ext/node/polyfills/testing.ts (#2…
1c7ae83 
…4310)

Towards #24236
iuioiua added a commit that referenced this issue Jun 24, 2024
@iuioiua
fix(ext/node): use primordials in ext/node/polyfills/timers.ts (#24311
dc4a88b 
)

Towards #24236
iuioiua added a commit that referenced this issue Jun 24, 2024
@iuioiua
fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_cp.js (#…
0833a16 
…24320)

Towards #24236
iuioiua added a commit that referenced this issue Jun 24, 2024
@iuioiua @satyarohith
fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_dir.ts (…
ff53506 
…#24319)

Towards #24236

---------

Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com>
Co-authored-by: Satya Rohith <me@satyarohith.com>
sbmsr pushed a commit to sbmsr/deno-1 that referenced this issue Jul 2, 2024
@iuioiua @sbmsr
fix(ext/node): use primordials in ext/node/polyfills/_brotli.js (de…
5c3e29a 
…noland#24235)

Towards denoland#24236
sbmsr pushed a commit to sbmsr/deno-1 that referenced this issue Jul 2, 2024
@iuioiua @sbmsr
fix(ext/node): use primordials in ext/node/polyfills/testing.ts (de…
9804dad 
…noland#24310)

Towards denoland#24236
sbmsr pushed a commit to sbmsr/deno-1 that referenced this issue Jul 2, 2024
@iuioiua @sbmsr
fix(ext/node): use primordials in ext/node/polyfills/timers.ts (den…
c2f7186 
…oland#24311)

Towards denoland#24236
sbmsr pushed a commit to sbmsr/deno-1 that referenced this issue Jul 2, 2024
@iuioiua @sbmsr
fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_cp.js (d…
a7944c7 
…enoland#24320)

Towards denoland#24236
sbmsr pushed a commit to sbmsr/deno-1 that referenced this issue Jul 2, 2024
@iuioiua @satyarohith @sbmsr
fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_dir.ts (…
9de9427 
…denoland#24319)

Towards denoland#24236

---------

Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com>
Co-authored-by: Satya Rohith <me@satyarohith.com>
zebreus pushed a commit to zebreus/deno that referenced this issue Jul 8, 2024
@iuioiua @zebreus
fix(ext/node): use primordials in ext/node/polyfills/_brotli.js (de…
1b346f4 
…noland#24235)

Towards denoland#24236
zebreus pushed a commit to zebreus/deno that referenced this issue Jul 8, 2024
@iuioiua @zebreus
fix(ext/node): use primordials in ext/node/polyfills/testing.ts (de…
01c5dd6 
…noland#24310)

Towards denoland#24236
zebreus pushed a commit to zebreus/deno that referenced this issue Jul 8, 2024
@iuioiua @zebreus
fix(ext/node): use primordials in ext/node/polyfills/timers.ts (den…
dd32497 
…oland#24311)

Towards denoland#24236
zebreus pushed a commit to zebreus/deno that referenced this issue Jul 8, 2024
@iuioiua @zebreus
fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_cp.js (d…
a298453 
…enoland#24320)

Towards denoland#24236
zebreus pushed a commit to zebreus/deno that referenced this issue Jul 8, 2024
@iuioiua @satyarohith @zebreus
fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_dir.ts (…
db2df8b 
…denoland#24319)

Towards denoland#24236

---------

Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com>
Co-authored-by: Satya Rohith <me@satyarohith.com>
@petamoriken petamoriken mentioned this issue Aug 11, 2024
Open
@jake-abed jake-abed mentioned this issue Sep 11, 2024
Merged
iuioiua pushed a commit that referenced this issue Sep 11, 2024
@jake-abed
fix(ext/node): use primordials in ext/node/polyfills/console.ts (#2…
87bc47b 
…5572)

Contributing toward #24236

- Swapped `Object.assign` for `ObjectAssign` primordial.
- Removed referencing TODO comment.

Please disregard if no longer desired.
@jake-abed jake-abed mentioned this issue Sep 12, 2024
Merged
satyarohith pushed a commit that referenced this issue Sep 13, 2024
@jake-abed
fix(ext/node): use primordials in ext/node/polyfills/wasi.ts (#25608)
d162733 
Toward #24236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers node compat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iuioiua