Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/crypto): support JWK export for HMAC #11864

Merged
merged 5 commits into from
Aug 29, 2021

Conversation

littledivy
Copy link
Member

Towards #11690

@bartlomieju bartlomieju added this to the 1.14.0 milestone Aug 28, 2021
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :-)

Unfortunate there are no WPT for this. We should consider upstreaming some.

Comment on lines +1020 to +1021
// TODO(@littledivy): Redundant break but deno_lint complains without it
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucacasonato lucacasonato merged commit 5ee2110 into denoland:main Aug 29, 2021
@littledivy littledivy deleted the jwk_export_hmac branch August 29, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants