feat(ext/crypto): generate ECDH keys #11870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for ECDH algorithm in SubtleCrypto#generateKey.
Closed
littledivy
reviewed
Aug 29, 2021
| @@ -162,7 +162,7 @@ pub async fn op_crypto_generate_key( | |||
|
|
|||
| private_key.to_pkcs8_der()?.as_ref().to_vec() | |||
| } | |||
| Algorithm::Ecdsa => { | |||
| Algorithm::Ecdsa | Algorithm::Ecdh => { | |||
There was a problem hiding this comment.
The ECKeyPair is generated using ring::signature::EcdsaKeyPair::generate_pkcs8. Is this the correct way?
There was a problem hiding this comment.
Yes. The spec says to generate an "Elliptic Curve key pair' for both cases. ECDSA and ECDH are two algorithms for encryption/decryption, and key agreement respectively. They both operate using EC keys though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ECDH algorithm in SubtleCrypto#generateKey.
Towards #11690