feat(ext/crypto) - support encrypt/decrypt with AES-CTR #13177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptographix
requested review from
bartlomieju,
bnoordhuis and
lucacasonato
as code owners
bnoordhuis
reviewed
Dec 29, 2021
ext/crypto/encrypt.rs
Outdated
| let mut cipher = Ctr::<B, F>::new(key.into(), counter.into()); | ||
|
|
||
| let mut ciphertext = data.to_vec(); | ||
| cipher.apply_keystream(&mut ciphertext); |
There was a problem hiding this comment.
Just checking to see if my understanding is correct: it's okay to use apply_keystream() instead of try_apply_keystream() because the ciphertext is always a multiple of the block size?
There was a problem hiding this comment.
As a stream cipher, any length of text is allowed, not being restricted to multiples of the block-size. There is a case where apply_keystream will throw, however, which is when the user tries to encrypt more than 2 ^ length x 16 bytes of data, which in our current worse case, is 128GB in a single call.
Altered to use try_apply_keystream as excess of caution.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #11690. Adds support for
AES-CTRalgorithm inencrypt()anddecrypt().Values of counter-length restricted to 32/64/128 as per common usage described in issue #13201.