Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/crypto): implement AES-GCM decryption #13319

Merged
merged 7 commits into from
Jan 14, 2022
Merged

feat(ext/crypto): implement AES-GCM decryption #13319

merged 7 commits into from
Jan 14, 2022

Conversation

littledivy
Copy link
Member

Towards #11690

@littledivy littledivy marked this pull request as ready for review January 10, 2022 06:21
cryptographix
cryptographix reviewed Jan 10, 2022
View reviewed changes
Copy link
Contributor

@cryptographix cryptographix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

ext/crypto/00_crypto.js Show resolved Hide resolved
ext/crypto/00_crypto.js Outdated Show resolved Hide resolved
ext/crypto/decrypt.rs Outdated Show resolved Hide resolved
@cryptographix
Copy link
Contributor

cryptographix commented Jan 10, 2022 •
edited
Loading

@littledivy - General question: Is there anywhere we can document the current restrictions on tag-size for AES-GCM, apart from the PRs which once merged become somewhat invisible?

AES-CTR has similar restrictions on counter-size ..

bnoordhuis
bnoordhuis approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR LGTM (and thanks!) but I second the suggestion from @seanwykes to de-duplicate the logic using generics.

@littledivy
Copy link
Member Author

@littledivy - General question: Is there anywhere we can document the current restrictions on tag-size for AES-GCM, apart from the PRs which once merged become somewhat invisible?

AES-CTR has similar restrictions on counter-size ..

@seanwykes I think these limitations can be in the manual once we add a WebCrypto section. (denoland/docs#107)

@littledivy littledivy merged commit 919ded1 into denoland:main Jan 14, 2022
@littledivy littledivy deleted the aes_gcm_decrypt branch January 14, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptographix cryptographix cryptographix left review comments

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @cryptographix @bnoordhuis