Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): implement crypto.Sign (RSA/PEM/SHA{224,256,384,512}) #18471

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 28, 2023

This PR implements crypto.Sign (createSign) API for node compat layer with support of RSA
key in pem format with digest algorithms SHA224, SHA256, SHA384, and SHA512.

part of #18455

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I will let @littledivy take another look before merging

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. one small nit

Cargo.toml Outdated
@@ -136,7 +137,7 @@ uuid = { version = "1.3.0", features = ["v4"] }
zstd = "=0.11.2"

# crypto
rsa = { version = "0.7.0", default-features = false, features = ["std", "pem"] }
rsa = { version = "0.7.0", default-features = false, features = ["std", "pem", "hazmat"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here why hazmat feature is used? "hazmat needed for PrehashSigner in ext/node"

@kt3k kt3k merged commit 4358ab2 into denoland:main Mar 28, 2023
@kt3k kt3k deleted the node-crypto-sign branch March 28, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants