refactor(node/crypto): port polyfill to Rust for randomInt, randomFill, randomFillSync #18658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
bartlomieju
reviewed
Apr 11, 2023
levex
force-pushed
the
node-crypto-random
branch
from
06c8139
to
7423a1d
Compare
levex
changed the title
levex
force-pushed
the
node-crypto-random
branch
3 times, most recently
from
9ef1ba8
to
d5a670c
Compare
levex
force-pushed
the
node-crypto-random
branch
from
d5a670c
to
cd806c2
Compare
|
Out of curiosity, shouldn't these be generated by a CSPRNG? or at least by |
We're using |
|
@sepehrst |
|
I was reading https://rust-random.github.io/book/guide-rngs.html#state-and-seeding and just missed the mention of |
levex
added a commit
that referenced
this pull request
Apr 12, 2023
…l, randomFillSync (#18658) Pretty much as per the title, I'd welcome some feedback especially around the array/buffer handling in the two randomFill functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much as per the title, I'd welcome some feedback especially around the
array/buffer handling in the two randomFill functions.