-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Support executing npm package lifecycle scripts (preinstall/install/postinstall) #24487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Jul 9, 2024
dsherret
reviewed
Jul 9, 2024
dsherret
reviewed
Jul 9, 2024
bartlomieju
reviewed
Jul 9, 2024
nathanwhit
commented
Jul 10, 2024
nathanwhit
commented
Jul 10, 2024
dsherret
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for running npm package lifecycle scripts, opted into via a new
--allow-scripts
flag.With this PR, when running
deno cache
(orDENO_FUTURE=1 deno install
) you can specify the--allow-scripts=pkg1,pkg2
flag to run lifecycle scripts attached to the given packages.Note at the moment this only works when
nodeModulesDir
is true (using the local resolver).When a package with un-run lifecycle scripts is encountered, we emit a warning suggesting things may not work and to try running lifecycle scripts. Additionally, if a package script implicitly requires
node-gyp
and it's not found on the system, we emit a warning.Extra things in this PR:
task.rs
into a separate module for reuseprocess.config
in order to supportnode-gyp
(it relies on a few variables being there)TODO:
Review notes:
node-gyp
, so it's pretty noisy