feat(cli): Add --env-file as alternative to --env #24555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkskyum
changed the title
birkskyum
changed the title
bartlomieju
reviewed
Aug 2, 2024
birkskyum
changed the title
birkskyum
force-pushed
the
env-file
branch
2 times, most recently
from
0c5fb96
to
acaa9d9
Compare
birkskyum
changed the title
birkskyum
force-pushed
the
env-file
branch
3 times, most recently
from
cdd6238
to
3beb8a7
Compare
|
Figured it out now. Clap doesn't support two .long(), but it does allow an .alias() which is an extra hidden .long(). |
|
@crowlKats , do you think it makes sense, and is technically possible with clap, to add a deprecation note to the |
|
@birkskyum clap itself can't do that, we'd have to do that ourselves (without much difficulty), however we are likely to keep it for the foreseeable future and then maybe remove it at some point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24528, see comment here on Deno 2
deno --env-filework like--env#24528This pr rename --env to --env-file for several reasons (see issue), but allow --env to keep working as an alias.
I've added 2 unit tests to make sure both --env and --env-file work