feat: vm rewrite #24596
Merged
feat: vm rewrite #24596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
added
node compat
node API polyfill
devsnek
force-pushed
the
vm-rewrite
branch
3 times, most recently
from
4a68335
to
7685a07
Compare
littledivy
approved these changes
Aug 6, 2024
| scope: &mut v8::HandleScope<'a, ()>, | ||
| object_template: v8::Local<v8::ObjectTemplate>, | ||
| mode: ContextInitMode, | ||
| microtask_queue: *mut v8::MicrotaskQueue, |
There was a problem hiding this comment.
nit:
Suggested change
| microtask_queue: *mut v8::MicrotaskQueue, | |
| microtask_queue: Option<NonNull<v8::MicrotaskQueue>>, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrite vm implementation to increase compat. vm.Module+importModuleDynamically callbacks should be added in a followup.