Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust suggestion for lockfile regeneration #25107

Merged
merged 4 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ deno_emit = "=0.44.0"
deno_graph = { version = "=0.81.2" }
deno_lint = { version = "=0.63.1", features = ["docs"] }
deno_lockfile.workspace = true
deno_npm = "=0.23.0"
deno_npm = "=0.23.1"
deno_package_json.workspace = true
deno_runtime = { workspace = true, features = ["include_js_files_for_snapshotting"] }
deno_semver = "=0.5.10"
Expand Down
4 changes: 2 additions & 2 deletions cli/graph_util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ fn enhanced_lockfile_error_message(err: &ModuleError) -> Option<String> {
"This could be caused by:\n",
" * the lock file may be corrupt\n",
" * the source itself may be corrupt\n\n",
"Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server."
"Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server."
),
package_nv,
checksum_err.actual,
Expand All @@ -824,7 +824,7 @@ fn enhanced_lockfile_error_message(err: &ModuleError) -> Option<String> {
"This could be caused by:\n",
" * the lock file may be corrupt\n",
" * the source itself may be corrupt\n\n",
"Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server."
"Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server."
),
specifier,
checksum_err.actual,
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/jsr_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
", actual_integrity);
test_context
.new_command()
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/npm_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1200,7 +1200,7 @@ fn lock_file_missing_top_level_package() {
"error: failed reading lockfile 'deno.lock'\n",
"\n",
"Caused by:\n",
" 0: The lockfile is corrupt. You can recreate it with --lock-write\n",
" 0: The lockfile is corrupt. Remove the lockfile to regenerate it.\n",
" 1: Could not find 'cowsay@1.5.0' in the list of packages.\n"
)
);
Expand Down Expand Up @@ -1483,7 +1483,7 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile at "[WILDCARD]deno.lock".
Investigate the lockfile; delete it to regenerate the lockfile at "[WILDCARD]deno.lock".
"#)
.assert_exit_code(10);
}
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/bundle/lockfile/check_error.out
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/specs/lockfile/auto_discover_lockfile/main.out
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
2 changes: 1 addition & 1 deletion tests/specs/lockfile/checksum_at_redirect/run.out
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
2 changes: 1 addition & 1 deletion tests/specs/lockfile/lock_check_err/lock_check_err.out
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
2 changes: 1 addition & 1 deletion tests/specs/lockfile/lock_check_err2/lock_check_err2.out
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
2 changes: 1 addition & 1 deletion tests/specs/lockfile/no_lock/fail.out
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.
Investigate the lockfile; delete it to regenerate the lockfile or --reload to reload the source code from the server.
2 changes: 1 addition & 1 deletion tests/specs/npm/lock_file_integrity_failure/main.out
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ This could be caused by:
* the lock file may be corrupt
* the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile at "[WILDCARD]lock.json".
Investigate the lockfile; delete it to regenerate the lockfile at "[WILDCARD]lock.json".