feat(upgrade): print info links for Deno 2 RC releases #25225
Merged
+96
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on decision what's the blog post link before landing this one. |
iuioiua
reviewed
Aug 28, 2024
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com> Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
cli/tools/upgrade.rs
Outdated
| && new_semver.patch == 0 | ||
| && new_semver.pre.first() == Some(&"rc".to_string()); | ||
|
|
||
| if is_deno_2_rc { |
There was a problem hiding this comment.
Probably in general when new_semver.major == 2 && (current_semver.pre.first() == Some(&"rc".to_string() || current_semver.major == 1)
That way 1.0 -> 2.0 (stable) upgrades will get this warning too.
There was a problem hiding this comment.
I updated it to that migration guide is printed for upgrading to Deno 2 RC, or when switching from Deno 1 to Deno 2.
I kept the remaining logic the same.
lucacasonato
pushed a commit
that referenced
this pull request
Sep 4, 2024
In addition to printing a blog post information (if it's available), this will also print a link to migration guide and the bug tracker. --------- Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com> Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to printing a blog post information (if it's available), this will also
print a link to migration guide and the bug tracker.