File and stdio I/O #846
File and stdio I/O #846
Conversation
ry
force-pushed
the
files
branch
2 times, most recently
from
e8bc817
to
2253538
Compare
Adds deno.stdin, deno.stdout, deno.stderr, deno.open(), deno.write(), deno.read(), deno.Reader, deno.Writer, deno.copy(). Fixes denoland#721. tests/cat.ts works.
| export const stdout = new File(1); | ||
| export const stderr = new File(2); | ||
|
|
||
| // TODO This is just a placeholder - not final API. |
| let mut table = FD_TABLE.lock().unwrap(); | ||
| let maybe_repr = table.get_mut(&self.fd); | ||
| match maybe_repr { | ||
| None => panic!("bad fd"), |
There was a problem hiding this comment.
It seems that this could actually happen, because an operation that closes the fs could overtake the async write.
(an argument for supporting some queuing, so it seems....)
But in the short term, maybe this shouldn't panic?
There was a problem hiding this comment.
I prefer to let things panic when we lack tests that demo a failure mode. That said - because the FD is checked first in the table - this shouldn’t ever happen...
| Repr::FsFile(ref mut f) => f.poll_read(buf), | ||
| Repr::Stdin(ref mut f) => f.poll_read(buf), | ||
| Repr::Stdout(_) | Repr::Stderr(_) => { | ||
| panic!("Cannot read from stdout/stderr") |
There was a problem hiding this comment.
Ultimately, it's a bit more complicated than that. We'll need some support for the case where a parent process opens fd `4' in the child process, like node did for the IPC channel, which means that we probably shouldn't have super special treatment for fdD 0-2.
(not that I would suggest we make reading from stdout a first class citizen).
There was a problem hiding this comment.
Hmm - not sure I know about that FD 4 things - but this is just a first pass... let’s see what happens later on - I’m not necessarily against preventing allowing write to stdin or read from stdout if it makes sense..
- Adds deno.stdin, deno.stdout, deno.stderr, deno.open(), deno.write(), deno.read(), deno.Reader, deno.Writer, deno.copy() denoland#846 - Print 'Compiling' when compiling TS. - Support zero-copy for writeFile() writeFileSync() denoland#838 - Fixes eval error bug denoland#837 - Make Deno multithreaded denoland#782 - console.warn() goes to stderr denoland#810 - Add deno.readlink()/readlinkSync() denoland#797 - Add --recompile flag denoland#801 - Use constructor.name to print out function type denoland#664 - Rename deno.argv to deno.args - Add deno.trace() denoland#795 - Continuous benchmarks https://denoland.github.io/deno/
- Adds deno.stdin, deno.stdout, deno.stderr, deno.open(), deno.write(), deno.read(), deno.Reader, deno.Writer, deno.copy() #846 - Print 'Compiling' when compiling TS. - Support zero-copy for writeFile() writeFileSync() #838 - Fixes eval error bug #837 - Make Deno multithreaded #782 - console.warn() goes to stderr #810 - Add deno.readlink()/readlinkSync() #797 - Add --recompile flag #801 - Use constructor.name to print out function type #664 - Rename deno.argv to deno.args - Add deno.trace() #795 - Continuous benchmarks https://denoland.github.io/deno/
Bumped versions for 0.299.0 Co-authored-by: bartlomieju <bartlomieju@users.noreply.github.com> Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Depends on #838