Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove glob experiment since glob support is released #10239

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Jul 18, 2024

What are you trying to accomplish?

We put glob support behind a feature flag so it could be rolled out and tested.

The feature is now released, we can remove this code.

Anything you want to highlight for special attention from reviewers?

Nope, I just got rid of dependency_files_for_globs and pulled the implementation up into dependency_files_for_multi_directories so the diff looks complicated.

How will you know you've accomplished your goal?

Removing code that is no longer being run, so we shouldn't see any change.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@jakecoffman jakecoffman changed the title remove glob experiment since it is rolled out remove glob experiment since glob support is released Jul 18, 2024
@jakecoffman jakecoffman marked this pull request as ready for review July 18, 2024 13:19
@jakecoffman jakecoffman requested a review from a team as a code owner July 18, 2024 13:19
@jakecoffman jakecoffman merged commit f2acf30 into main Jul 18, 2024
121 checks passed
@jakecoffman jakecoffman deleted the remove-glob-experiment branch July 18, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants