remove glob experiment since glob support is released #10239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
We put glob support behind a feature flag so it could be rolled out and tested.
The feature is now released, we can remove this code.
Anything you want to highlight for special attention from reviewers?
Nope, I just got rid of
dependency_files_for_globs
and pulled the implementation up intodependency_files_for_multi_directories
so the diff looks complicated.How will you know you've accomplished your goal?
Removing code that is no longer being run, so we shouldn't see any change.
Checklist