Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorbet support arm64 macOS natively #10662

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

JamieMagee
Copy link
Contributor

What are you trying to accomplish?

Update Sorbet to 0.5.11577, the first version that natively supports arm64 macOS instead of relying on Rosetta emulation.

Anything you want to highlight for special attention from reviewers?

Also updated some related tooling

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@JamieMagee JamieMagee requested a review from a team as a code owner September 23, 2024 20:29
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Sep 23, 2024
@JamieMagee JamieMagee force-pushed the jamiemagee/sorbet-universal-darwin branch 2 times, most recently from 6456ca2 to b61e464 Compare September 23, 2024 21:00
@github-actions github-actions bot added L: terraform Terraform packages L: javascript labels Sep 24, 2024
@JamieMagee JamieMagee force-pushed the jamiemagee/sorbet-universal-darwin branch 2 times, most recently from 7a27059 to 32a2715 Compare September 26, 2024 14:40
@JamieMagee JamieMagee force-pushed the jamiemagee/sorbet-universal-darwin branch 2 times, most recently from d431a96 to 886fa40 Compare October 7, 2024 20:47
Copy link
Contributor

@sachin-sandhu sachin-sandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the PR

@sachin-sandhu sachin-sandhu force-pushed the jamiemagee/sorbet-universal-darwin branch from 886fa40 to 1e4e4e0 Compare October 8, 2024 00:41
@sachin-sandhu sachin-sandhu merged commit ce21ef4 into main Oct 8, 2024
124 checks passed
@sachin-sandhu sachin-sandhu deleted the jamiemagee/sorbet-universal-darwin branch October 8, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: javascript L: terraform Terraform packages sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants