raise specific error when no update was possible #10685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the NuGet updater cannot perform any update, jobs currently fail with
unknown_error
which comes from here:dependabot-core/updater/lib/dependabot/dependency_change_builder.rb
Line 73 in dddd7b2
This isn't very descriptive and makes it difficult to investigate the
unknown_error
bucket, especially since in this case we know exactly what went wrong.The fix is to add a new error type that represents this scenario and raise it directly in the NuGet updater. This has the benefit of making the call stack more usable.
The error type string
update_not_possible
is already well-known.