rearrange NuGet error handling to one location in full runner #10692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
changed the title
brettfo
force-pushed
the
dev/brettfo/nuget-updater-common-error-handling
branch
2 times, most recently
from
1deee01
to
6fe7bc6
Compare
ryanbrandenburg
approved these changes
Sep 30, 2024
brettfo
force-pushed
the
dev/brettfo/nuget-updater-common-error-handling
branch
from
6fe7bc6
to
324aaf9
Compare
kbukum1
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR will not be live, even when merged. All of this behavior is behind an experiment which will not be enabled for some time.
This updates the full end-to-end update runner (not yet in production) for NuGet by rearranging the error handling. The individual tools used by the current Ruby updater remain unchanged, but everything else has been refactored so that one single place of error handling could be added to
RunWorker.cs. This involved creating new types to representprivate_source_authentication_error,dependency_file_not_found, andunknown_erroras a catch-all.The changes to
AnalyzeWorker.cs,DiscoveryWorker.cs, andUpdaterWorker.csare simply to move thetry/catchblocks to a different function.Future work will be to add support for more error types.