report specific error when project cannot be restored #10720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-no-package-found
branch
from
084dbf8
to
f85188b
Compare
brettfo
commented
Oct 7, 2024
| } | ||
|
|
||
| // this is a convenient method for tests | ||
| internal async Task<UpdateOperationResult> RunWithErrorHandlingAsync(string repoRootPath, string workspacePath, string dependencyName, string previousDependencyVersion, string newDependencyVersion, bool isTransitive) |
There was a problem hiding this comment.
This refactoring makes the unit tests easier to write.
brettfo
commented
Oct 7, 2024
| @@ -192,4 +192,67 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| describe "#ensure_no_errors" do | |||
There was a problem hiding this comment.
Previously we didn't have unit tests for converting updater errors into Ruby errors; this fixes that for all cases.
brettfo
force-pushed
the
dev/brettfo/nuget-no-package-found
branch
3 times, most recently
from
b07a83d
to
77d491e
Compare
JamieMagee
approved these changes
Oct 7, 2024
kbukum1
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a required package is missing from all sources in a
packages.configscenario, reportUpdateNotPossibleinstead ofunknown_error.An instance of this was seen where a
NuGet.Configfile was using an Azure DevOps feed with a restricted view that didn't have all packages listed.