Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve usage of atomics #258

Merged
merged 3 commits into from
Aug 5, 2022

Conversation

GaryOderNichts
Copy link
Contributor

  • Replaces the usage of the built-in atomics with the OS* atomics from coreinit.
    This avoids a hardware bug described here.

    There appears to be a bug that affects load-exclusive and store-exclusive instructions (an explicit cache flush is required)

    The gcc built-in atomics do not emit a cache flush which might cause issues in the current wut lock implementation.

  • Uses OSSwapAtomic in wutstdc++'s once implementation where a compare isn't necessary.

  • Uses OSCompareAndSwapAtomicEx to directly update the oldSize in the newlib sbrk implementation.

@fincs fincs merged commit 42292fa into devkitPro:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants