Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable LDAP_AUTHENTICATION_TYPE in .env.model #217

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Variable LDAP_AUTHENTICATION_TYPE in .env.model #217

merged 1 commit into from
Apr 18, 2023

Conversation

c8y3
Copy link
Contributor

@c8y3 c8y3 commented Apr 18, 2023

When the LDAP_AUTHENTICATION_TYPE is not present in the .env file, we get the following error during an ldap authentication:

ERROR :: login_routes :: _authenticate_ldap :: 'NoneType' object has no attribute 'lower'

So I am proposing this pull request because it took me some time to understand what was missing when configuring authentication with ldap for the first time.

@whikernel whikernel self-requested a review April 18, 2023 14:45
whikernel
whikernel approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@whikernel whikernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks for the fix @c8y3

@whikernel whikernel merged commit 6f1c198 into dfir-iris:master Apr 18, 2023
@c8y3 c8y3 deleted the env_ldap_authentication_type branch April 18, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whikernel whikernel whikernel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c8y3 @whikernel