Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publisher): initialize the atomic variable #1889

Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix(publisher): initialize the atomic variable #1889

merged 1 commit into from
Feb 28, 2023

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Feb 28, 2023 •
edited by joshua-goldstein
Loading

Bug came in #1878 , resolve this bug by initializing atomic variable

@coveralls
Copy link

Coverage Status

Coverage: 60.749% (+19.5%) from 41.229% when pulling e09e92b on aman/bugfix into 0e2ebb1 on main.

@joshua-goldstein joshua-goldstein changed the base branch from main-deprecated-v4 to main February 28, 2023 20:24
skrdgraph
skrdgraph approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshua-goldstein joshua-goldstein merged commit ebd6fed into main Feb 28, 2023
@joshua-goldstein joshua-goldstein deleted the aman/bugfix branch February 28, 2023 20:24
@joshua-goldstein joshua-goldstein changed the title chore(bug): initialize the atomic variable fix(publisher): initialize the atomic variable Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-goldstein joshua-goldstein joshua-goldstein approved these changes

@skrdgraph skrdgraph skrdgraph approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mangalaman93 @coveralls @joshua-goldstein @skrdgraph