Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds method to check for non counted Repeat Group at current index #1408

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

shubham1g5
Copy link
Contributor

Technical Summary

Adds method to check for non counted Repeat Group at current index to support FP commit here

Safety Assurance

Just a supporting method with only usage in FP PR to determine whether a repeat supports delete operation

Automated test coverage

Added in FP commit here

QA Plan

None

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

Copy link
Contributor

@MartinRiese MartinRiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 👍

@shubham1g5 shubham1g5 merged commit 9242d2c into formplayer Jun 7, 2024
2 checks passed
@shubham1g5 shubham1g5 deleted the isNonCountedRepeat branch June 7, 2024 13:05
@shubham1g5 shubham1g5 restored the isNonCountedRepeat branch June 7, 2024 13:07
@shubham1g5
Copy link
Contributor Author

duplicate this PR 3f106d4

@shubham1g5
Copy link
Contributor Author

duplicate this PR 3f106d4 3f106d4

@shubham1g5 shubham1g5 deleted the isNonCountedRepeat branch June 7, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants