Unpinning numpy version, addressing warnings #1004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #964.
All tests ran successfully using Numpy v.2.0.1. However, the following new warning occurred:
This was a simple fix. MiniDifi uses Numpy record arrays in which the ssObjectID column was being typed as
ssObjectId=f"a{nameLen}"
. Changed this tossObjectId=f"S{nameLen}"
in all places. This fix is backwards-compatible at least as far back as Numpy version 1.26.4 so it shouldn't break anyone's existing environments.Review Checklist for Source Code Changes