Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for issues found while conda packaging #976

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

mjuric
Copy link
Member

@mjuric mjuric commented Jul 11, 2024

Fixes # .

Describe your changes.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.61%. Comparing base (39cf35f) to head (59102a5).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   80.69%   80.61%   -0.09%     
==========================================
  Files          69       69              
  Lines        3139     3079      -60     
==========================================
- Hits         2533     2482      -51     
+ Misses        606      597       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjuric mjuric changed the title WIP: Bug fixes for issues found while conda packaging Bug fixes for issues found while conda packaging Jul 11, 2024
@mjuric mjuric merged commit d472a6b into dirac-institute:main Jul 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant