Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding version checker, better error messages #991

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

astronomerritt
Copy link
Collaborator

Fixes #983.

  • Error messages in the sorchaArguments dataclass are now more informative and refer to the relevant command-line argument.
  • Updated the unit test.

Fixes #981.

  • Added back in Mario's code for a --version command line argument.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.79%. Comparing base (abac8fe) to head (6423254).
Report is 2 commits behind head on main.

Files Patch % Lines
src/sorcha/utilities/sorchaArguments.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
- Coverage   80.83%   80.79%   -0.04%     
==========================================
  Files          69       69              
  Lines        3084     3083       -1     
==========================================
- Hits         2493     2491       -2     
- Misses        591      592       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mschwamb
Copy link
Collaborator

mschwamb commented Aug 3, 2024

It would be good for @mjuric to confirm the version stuff is okay. I think it is but a quickly double check would be helpful.

@mschwamb mschwamb merged commit 7a8cbc9 into dirac-institute:main Aug 5, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make a more informative error message Add ability to check sorcha version from the command line
2 participants