-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(WebSocketShard): error event handling #10436
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10436 +/- ##
==========================================
+ Coverage 50.79% 50.80% +0.01%
==========================================
Files 228 228
Lines 20689 20679 -10
Branches 1258 1258
==========================================
- Hits 10508 10505 -3
+ Misses 10137 10130 -7
Partials 44 44 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.connection.onmessage = null; |
no longer relevant
f47273f
to
3cf1d56
Compare
Please describe the changes this PR makes and why it should be merged:
Fixes #10397
Internal ref: https://discord.com/channels/222078108977594368/999796393810067607/1271166923500945419