-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(voice): Add vitest #10472
base: main
Are you sure you want to change the base?
test(voice): Add vitest #10472
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10472 +/- ##
==========================================
+ Coverage 35.48% 38.16% +2.68%
==========================================
Files 228 227 -1
Lines 14308 15180 +872
Branches 1254 1401 +147
==========================================
+ Hits 5077 5794 +717
- Misses 9187 9374 +187
+ Partials 44 12 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can you try to rebase your PR? Just start the rebase, and every time you get a merge issue on pnpm-lock.yaml, just run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a vitest config file for this too 🙏 Personally don't like relying on defaults
1d522d2
to
d0ee16b
Compare
Is what I've done okay? It falls back to the config in the monorepo top level, and nothing else is currently needed, but there so that it may be edited if needed |
Turns out only rest has a custom vitest.config.ts file 🥴. It's fine as is 🫡 |
Please describe the changes this PR makes and why it should be merged:
This is to update voice to use vitest instead of jest. It was ignored previously because the mocks are annoying to convert.
The tests compile and pass as shown by the CI.
Status and versioning classification: