APPS-2624 Put awscliv2 ecr get-login-password into retry loop (#473)

RELEASE_NOTES.md

@@ -3,6 +3,7 @@
 ## in develop
 
 * Added [DIY Docker image instructions](./scripts/docker_image/). This replaces the Docker image published to Docker Hub, which is deprecated and will be removed after November 1, 2024.
+* Added exponential backoff and retry, including attempt to get password from AWS, in ECR docker script template
 
 ## 2.11.7 2024-09-12
 

compiler/src/main/resources/templates/ecr_docker_preamble.ssp

@@ -27,23 +27,28 @@
     # disable echo to avoid logging password
     set +x
 
-    # get the password from the aws client
-    password=${bashDollar}(awscliv2 ecr get-login-password --region ${bashDollar}{AWS_REGION})
-
     # Log into docker. Retry several times.
     i=0
     while [[ ${bashDollar}i -le 5 ]]; do
         # don't exit if docker command fails - retry instead
         set +e
-        # TODO: use credential helper instead https://docs.docker.com/engine/reference/commandline/login/
-        echo ${bashDollar}{password} | docker login ${bashDollar}{DOCKER_REGISTRY} --username AWS --password-stdin
-        rc=${bashDollar}?
-        set -e
-        if [[ ${bashDollar}rc == 0 ]]; then
-            break
+
+        # get the password from the aws client
+        password=${bashDollar}(awscliv2 ecr get-login-password --region ${bashDollar}{AWS_REGION})
+        if [[ ${bashDollar}? -ne 0 ]]; then
+            echo "Could not get password from AWS"
+        else
+            # TODO: use credential helper instead https://docs.docker.com/engine/reference/commandline/login/
+            echo ${bashDollar}{password} | docker login ${bashDollar}{DOCKER_REGISTRY} --username AWS --password-stdin
+            rc=${bashDollar}?
+            if [[ ${bashDollar}rc == 0 ]]; then
+                break
+            fi
         fi
+
+        set -e
+        sleep ${bashDollar}((2**i))
         i=${bashDollar}((i + 1))
-        sleep 3
         echo "retry docker login (${bashDollar}i)"
     done