-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to CLI build #6865
Add support to CLI build #6865
Conversation
I see a couple of issues. Both are likely related and may be summarized as
Baseline: CentOS 7.5 x86_64. (Similar results seen on OSX Darwin 17.7.0)
Case 1: Images not (re)tagged correctly after first build.
Case 2:
|
|
@orisano : up --build. |
Maybe resolve that |
I will test this again and provide feedback. However I do feel that in the broader scheme of things, we should be adding something to the integration test suite in this PR. Not sure of this is covered in any any testcases already.
I'm happy to dig into the code, if that helps to move this PR along. |
Yes, it fixes the issue for both |
I implemented a prototype of |
orisano@a633c9a |
@ulyssessouza What could I do? |
Thanks a lot @orisano ! Then I think the scope of this PR is closed. |
bbaebd8
to
c393540
Compare
c393540
to
d752cc8
Compare
Please add this commit. Maybe, it is the mistake of conflict resolves. |
This includes can be enabled by setting the env var `COMPOSE_NATIVE_BUILDER=1`. Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp> Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Signed-off-by: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
f9fb94a
to
a6de26d
Compare
@orisano Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @orisano for the contribution! This feature will be available in the next RC. |
Thanks everyone! Looking forward to see people use this feature 👍 (be sure to post feedback!) |
When it would be possible to start using it in docker compose? |
@itaymelamed In the next release candidate (1.25.0-rc3). It has no specific date but it's comming very soon (weeks). |
We've used this in our CI fairly extensively over the past few weeks. Thanks @ulyssessouza |
Thanks for the feedback, @abhaychrungoo ! That's good to hear 🤗 |
First of all, it works great and getting a lot faster builds as a result. Thanks! I installed latest via:
Result: I noticed a difference now in behavior with |
@bkaid thanks for reporting: would you be able to open a new issue and provide a minimum reproduction example? |
@thaJeztah Sorry - disregard. I tried on latest release docker-compose.yml:
This will restart my service and keep showing updated logs and not exit: This will restart my service in the background and exit: |
@ulyssessouza no pressure but it starting to become months :( |
I'd like to use |
@smamessier I'm interested in support for this as well. |
This PR is included in the 1.25.0-rc3 release that you can find here. It will also be part of the next Docker Desktop edge release. |
@smamessier I'm also interested in this feature! |
@chris-crone it would be nice to see this mentioned in the release docs. It looks like a pretty significant new feature. |
How do I execute the equivalent of |
@pasqoo not supported yet, but there's a PR working on that to add it to the compose-file syntax; #7046. It won't be added as a command-line flag, because you want to control which builds have access to your ssh-agent (as the compose file may have multiple builds, and only some of them could need access) |
@thaJeztah do you know when --ssh feature will be released? |
This add support for building with the CLI by setting the env var
COMPOSE_DOCKER_CLI_BUILD=1
.This feature can be used both by
docker-compose build
anddocker-compose up --build
.Note that this feature is EXPERIMENTAL, therefore a warning message is printed on every execution
Signed-off-by: Nao YONASHIRO yonashiro@r.recruit.co.jp
Signed-off-by: Ulysses Souza ulysses.souza@docker.com
This PR is a squashed and resumed version of #6584
As a followup we need to check following points in other PRs
--progress
flag indocker-compose build
to control the format of the outputbuild
andup --build