Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute entrypoints manifest #1152

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

shramee
Copy link
Contributor

@shramee shramee commented Nov 3, 2023

New computed field on Contract in manifest...

      contract.computed = [
        // For `#[computed]`
        {
          "contract": "actions",
          "entrypoint": "entrypoint_name",
          "component": null
        },
        // For `#[computed(ModelName)]`
        {
          "contract": "actions",
          "entrypoint": "entrypoint_name",
          "component": "ModelName"
        }
      ];

⚠️ At the moment only FreeFunctions are supported (not the ones in impl).

Copy link
Contributor

@tarrencev tarrencev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback but generally looks good

crates/dojo-lang/src/plugin.rs Outdated Show resolved Hide resolved
crates/dojo-lang/src/plugin.rs Outdated Show resolved Hide resolved
Use syntax nodes for param type
Update crates/dojo-lang/src/plugin.rs
@shramee shramee merged commit 4a6843d into dojoengine:main Nov 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants