Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(katana-core): replace compiled class hash with class hash #1404

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 8, 2024

Replace genesis state predefined declared classes map's key from compiled class hash to class hash. The intended type should be ClassHash and not CompiledClassHash.

The class hash for the generated Account also has to be changed as it is supposed to be the class hash. Changing this value means that the resulting account address is also changed.

This is easily missed because both types are essentially the same as they're both an alias for FieldElement.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36e5853) 67.13% compared to head (b97626b) 67.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1404      +/-   ##
==========================================
- Coverage   67.13%   67.12%   -0.01%     
==========================================
  Files         231      231              
  Lines       20858    20844      -14     
==========================================
- Hits        14003    13992      -11     
+ Misses       6855     6852       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit 3bb35a6 into dojoengine:main Jan 10, 2024
10 checks passed
@kariy kariy deleted the fix-compiled-class-hash branch January 10, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants