Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example spawn-and-move #1413

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

dpinones
Copy link
Contributor

@dpinones dpinones commented Jan 10, 2024

  • Update the syntax of example spawn-and-move based on the dojo-starter repository.
  • Update outdated readme

@dpinones dpinones marked this pull request as ready for review January 10, 2024 22:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87599f9) 67.62% compared to head (04f57a4) 67.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1413   +/-   ##
=======================================
  Coverage   67.62%   67.63%           
=======================================
  Files         218      218           
  Lines       21060    21060           
=======================================
+ Hits        14242    14243    +1     
+ Misses       6818     6817    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that @dpinones! Good fresh cairo code on enums was definitely needed.

Could you run the README flow again using the latest Katana (built on main) and adjust the variables to it? I've left one comment on a important spot (the Scarb manifest), but you may need to adjust more in the README as addresses will change.

This because you're surely using the Katana from v0.4.4 and you should be using new accounts addresses for that as this will be included in the next release. 👍

examples/spawn-and-move/Scarb.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @dpinones!

@glihm glihm merged commit 66b16f8 into dojoengine:main Jan 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants